Integrate kafka capacity planner with buffers #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramsrivatsa
force-pushed
the
ramsrivatsak/integrate-kafka-with-buffers
branch
from
73ac91d to
773b600
Compare
ramsrivatsa
force-pushed
the
ramsrivatsak/integrate-kafka-with-buffers
branch
from
773b600 to
c65d9c0
Compare
| desired={ | ||
| # Amount of compute buffer that we need to reserve in addition to | ||
| # cpu_headroom_target that is reserved on a per instance basis | ||
| "compute": Buffer(ratio=1.5, components=[BufferComponent.compute]), |
There was a problem hiding this comment.
ratio=2.5 here for tier0 and tier1 (to target 40% CPU utilization max on instance). It can be lower(1.5) for tier=2 and tier=3
| # cpu_headroom_target that is reserved on a per instance basis | ||
| "compute": Buffer(ratio=1.5, components=[BufferComponent.compute]), | ||
| # This makes sure we use only 25% of the available storage | ||
| "storage": Buffer(ratio=4.0, components=[BufferComponent.storage]), |
There was a problem hiding this comment.
this can be 2.5X for storage (we are ok using upto 40% of disk)
| "background": Buffer( | ||
| ratio=2.0, | ||
| components=[ | ||
| BufferComponent.cpu, |
There was a problem hiding this comment.
how is background cpu buffer different from the compute buffer above?
| core_count=needed_cores, | ||
| target_shape=instance, | ||
| reference_shape=reference_shape, | ||
| needed_cores = int(capacity_requirement.cpu_cores.mid) |
There was a problem hiding this comment.
just using mid cpu cores for needed cores felt not very accurate, hence I had the logic that you have removed. What is rationale for using the cpu.mid here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.