Change buffers implentation to assume per node utilization #142
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashdeepgoel
force-pushed
the
feature/change-to-per-node
branch
2 times, most recently
from
3d2c27b to
b95337c
Compare
akashdeepgoel
force-pushed
the
feature/change-to-per-node
branch
from
b95337c to
4f5d664
Compare
jolynch
requested changes
May 28, 2025
There was a problem hiding this comment.
I am not sure this is consistent with these functions, and ideally would like to see test coverage of these functions @ayushisingh29 that would catch this kind of change (and signal that the dev is changing the meaning of these common functions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.