-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #564 from Sineaggi/add-support-for-configuration-c…
…ache Fix configuration cache issue
- Loading branch information
Showing
5 changed files
with
236 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/InternalSimpleDependency.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * | ||
| * Copyright 2020 Netflix, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package com.netflix.graphql.dgs.codegen.gradle | ||
|
|
||
| import java.io.Serializable | ||
|
|
||
| data class InternalSimpleDependency(val name: String, val group: String?) : Serializable |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
163 changes: 163 additions & 0 deletions
163
...adle/src/test/kotlin/com/netflix/graphql/dgs/CodegenGradlePluginConfigurationCacheTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| * | ||
| * Copyright 2020 Netflix, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package com.netflix.graphql.dgs | ||
|
|
||
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.gradle.testkit.runner.GradleRunner | ||
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.io.TempDir | ||
| import java.io.File | ||
| import java.net.URI | ||
| import java.nio.file.* | ||
| import kotlin.io.path.createDirectories | ||
| import kotlin.io.path.writeText | ||
|
|
||
| class CodegenGradlePluginConfigurationCacheTest { | ||
|
|
||
| @TempDir | ||
| lateinit var projectDir: File | ||
|
|
||
| @Test | ||
| fun `Test if configuration cache can be reused successfully`() { | ||
| prepareBuildGraphQLSchema( | ||
| """ | ||
| type Query { | ||
| test: String | ||
| } | ||
| """.trimMargin() | ||
| ) | ||
|
|
||
| prepareBuildGradleFile( | ||
| """ | ||
| plugins { | ||
| id 'java' | ||
| id 'com.netflix.dgs.codegen' | ||
| } | ||
| repositories { | ||
| mavenCentral() | ||
| } | ||
| sourceCompatibility = 1.8 | ||
| targetCompatibility = 1.8 | ||
| generateJava { | ||
| packageName = 'com.netflix.testproject.graphql' | ||
| generateClient = true | ||
| } | ||
| // Need to disable the core conventions since the artifacts are not yet visible. | ||
| codegen.clientCoreConventionsEnabled = false | ||
| """.trimMargin() | ||
| ) | ||
|
|
||
| val runner = GradleRunner.create() | ||
| .withProjectDir(projectDir) | ||
| .withPluginClasspath() | ||
| .withDebug(true) | ||
| .withArguments( | ||
| "--stacktrace", | ||
| "--info", | ||
| "--configuration-cache", | ||
| "generateJava", | ||
| "build" | ||
| ) | ||
|
|
||
| runner.build() // First build, warm up cache | ||
| val result = runner.build() // Second build, should use cache | ||
|
|
||
| assertThat(result.output).contains("Reusing configuration cache.") | ||
| } | ||
|
|
||
| @Test | ||
| fun `Test if configuration cache can be reused successfully with external schemas`() { | ||
| prepareSchemaJar( | ||
| """ | ||
| type Query { | ||
| test: String | ||
| } | ||
| """.trimMargin() | ||
| ) | ||
|
|
||
| prepareBuildGradleFile( | ||
| """ | ||
| plugins { | ||
| id 'java' | ||
| id 'com.netflix.dgs.codegen' | ||
| } | ||
| repositories { | ||
| mavenCentral() | ||
| } | ||
| dependencies { | ||
| // other dependencies | ||
| dgsCodegen files("$projectDir/schema.jar") | ||
| } | ||
| sourceCompatibility = 1.8 | ||
| targetCompatibility = 1.8 | ||
| generateJava { | ||
| packageName = 'com.netflix.testproject.graphql' | ||
| generateClient = true | ||
| } | ||
| // Need to disable the core conventions since the artifacts are not yet visible. | ||
| codegen.clientCoreConventionsEnabled = false | ||
| """.trimMargin() | ||
| ) | ||
|
|
||
| val runner = GradleRunner.create() | ||
| .withProjectDir(projectDir) | ||
| .withPluginClasspath() | ||
| .withDebug(true) | ||
| .withArguments( | ||
| "--stacktrace", | ||
| "--info", | ||
| "--configuration-cache", | ||
| "generateJava", | ||
| "build" | ||
| ) | ||
|
|
||
| runner.build() // First build, warm up cache | ||
| val result = runner.build() // Second build, should use cache | ||
|
|
||
| assertThat(result.output).contains("Reusing configuration cache.") | ||
| } | ||
|
|
||
| private fun prepareSchemaJar(content: String) { | ||
| val env = mapOf("create" to "true") | ||
| val uri: URI = URI.create("jar:file:$projectDir/schema.jar") | ||
| FileSystems.newFileSystem(uri, env).use { zipfs -> | ||
| val pathInZipfile: Path = zipfs.getPath("/schema/schema.graphql") | ||
| pathInZipfile.parent.createDirectories() | ||
| pathInZipfile.writeText(content) | ||
| } | ||
| } | ||
|
|
||
| private fun prepareBuildGradleFile(content: String) { | ||
| writeProjectFile("build.gradle", content) | ||
| } | ||
|
|
||
| private fun prepareBuildGraphQLSchema(content: String) { | ||
| writeProjectFile("src/main/resources/schema/schema.graphql", content) | ||
| } | ||
|
|
||
| private fun writeProjectFile(relativePath: String, content: String) { | ||
| val file = File(projectDir, relativePath) | ||
| file.parentFile.mkdirs() | ||
| file.writeText(content) | ||
| } | ||
| } |