Issue warning if PKL does not contain assets of type "text/xml" #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- not depending on correct mime type in PKL in order to identify referenced files as OPL or CPL - instead looking at all non-MXF assets to find CPLs/OPLs and THEN validating that their mime type is stated correctly in the PKL
…beled as text/xml CPL/OPL parsing will continue to depend on the correct mime type in PKL, but a warning is provided if a PKL does not contain any assets of type text/xml
fschleich
changed the title
…ApplicationCompositions - in case implementation of analyzeApplicationCompositions won't depend on mime type in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKLs are not required to reference any CPL/OPL files, but they typically do. This update adds a WARNING if a PKL does not contain any assets of type "text/xml".
Resolves #303.