Adding parsing for 'J2KExtendedCapabilities' stored in the MXF header's 'JPEG2000SubDescriptor'. #382
Conversation
danielhdz13-netflix
requested review from
palemieux,
fschleich and
davidt-netflix
… be used for InterchangeObject inheritors. Passed in byteProvider directly.
There was a problem hiding this comment.
A 50MB file isn't ideal, to have committed to the git repo. Do we have easy access to a much smaller HT J2K MXF? Or the ability to craft one ourselves?
We already have a couple of larger files in the test resources. So it isn't a big deal if we can't make this smaller. But its always good to try, when we can. The types of files covered by this might mean it is simply not possible to make a "small" test file though.
There was a problem hiding this comment.
Good catch - just replaced it with a ~4MB file.
| else if (field.getType() == J2KExtendedCapabilities.class) { | ||
| J2KExtendedCapabilities j2KExtendedCapabilities = new J2KExtendedCapabilities(byteProvider); | ||
| field.set(object, j2KExtendedCapabilities); | ||
| } |
There was a problem hiding this comment.
I agree that it does feel very clean to recognize this as a top-level type. But I can't immediately think of a cleaner way to handle this within the current code. We are also already doing something similar for JPEG2000PictureComponentBO a little further down. So this is probably okay.
We can consider this as something to clean up in a future refactoring, if we make improvements to the way we recognize MXF properties.
| public final class J2KExtendedCapabilities { | ||
|
|
||
| @MXFProperty(size=4) protected final Integer pCap = null; | ||
| @MXFProperty(size=0, depends=true) protected final CompoundDataTypes.MXFCollections.MXFCollection<Short> cCapi = null; |
There was a problem hiding this comment.
Lets change this to cCap, as the 'i' in the spec document is just used to indicate index.
No description provided.