Weiihann/fix test race #2427
Draft
Weiihann/fix test race #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix nil blockid interface
remove equal
This reverts commit 48b4202.
Co-authored-by: Daniil Ankushin <ankushin.daniil42@gmail.com> Signed-off-by: Ng Wei Han <47109095+weiihann@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2427 +/- ##
==========================================
- Coverage 74.55% 74.31% -0.25%
==========================================
Files 113 113
Lines 13040 13124 +84
==========================================
+ Hits 9722 9753 +31
- Misses 2588 2633 +45
- Partials 730 738 +8 ☔ View full report in Codecov by Sentry. |
infrmtcs
reviewed
Feb 7, 2025
| @@ -49,12 +63,23 @@ func (ws *Websocket) WithListener(listener NewRequestListener) *Websocket { | |||
| // ServeHTTP processes an HTTP request and upgrades it to a websocket connection. | |||
| // The connection's entire "lifetime" is spent in this function. | |||
| func (ws *Websocket) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| // Check connection limit | |||
| if ws.connCount.Load() >= ws.maxConns { | |||
There was a problem hiding this comment.
I think race condition can cause the connection count going over the limit. For example, 2 requests reach this at the same time when the connCount is 2047, both of them will pass this check and acquire a new connection.
I think a simpler option to consider is to use https://pkg.go.dev/golang.org/x/sync@v0.11.0/semaphore.
There was a problem hiding this comment.
You're right, thanks for catching that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.