fix: Use INSUFFICIENT_RESOURCES_FOR_VALIDATE instead of INSUFFICIENT_MAX_FEE in v8

clients/gateway/gateway.go

@@ -19,11 +19,12 @@
 )
 
 var (
 	InvalidContractClass            ErrorCode = "StarknetErrorCode.INVALID_CONTRACT_CLASS"
 	UndeclaredClass                 ErrorCode = "StarknetErrorCode.UNDECLARED_CLASS"
 	ClassAlreadyDeclared            ErrorCode = "StarknetErrorCode.CLASS_ALREADY_DECLARED"
 	InsufficientMaxFee              ErrorCode = "StarknetErrorCode.INSUFFICIENT_MAX_FEE"
+	InsufficientResourcesForValidate ErrorCode = "StarknetErrorCode.INSUFFICIENT_RESOURCES_FOR_VALIDATE"
 	InsufficientAccountBalance      ErrorCode = "StarknetErrorCode.INSUFFICIENT_ACCOUNT_BALANCE"
 	ValidateFailure                 ErrorCode = "StarknetErrorCode.VALIDATE_FAILURE"
 	ContractBytecodeSizeTooLarge    ErrorCode = "StarknetErrorCode.CONTRACT_BYTECODE_SIZE_TOO_LARGE"
 	DuplicatedTransaction           ErrorCode = "StarknetErrorCode.DUPLICATED_TRANSACTION"

rpc/rpccore/rpccore.go

@@ -33,7 +33,7 @@
 }
 
 var (
 	ErrContractNotFound                = &jsonrpc.Error{Code: 20, Message: "Contract not found"}
 	ErrBlockNotFound                   = &jsonrpc.Error{Code: 24, Message: "Block not found"}
 	ErrInvalidTxHash                   = &jsonrpc.Error{Code: 25, Message: "Invalid transaction hash"}
 	ErrInvalidBlockHash                = &jsonrpc.Error{Code: 26, Message: "Invalid block hash"}
@@ -52,6 +52,7 @@
 	ErrInternal                        = &jsonrpc.Error{Code: jsonrpc.InternalError, Message: "Internal error"}
 	ErrInvalidTransactionNonce         = &jsonrpc.Error{Code: 52, Message: "Invalid transaction nonce"}
 	ErrInsufficientMaxFee              = &jsonrpc.Error{Code: 53, Message: "Max fee is smaller than the minimal transaction cost (validation plus fee transfer)"} //nolint:lll
+	ErrInsufficientResourcesForValidate = &jsonrpc.Error{Code: 53, Message: "The transaction’s resources don’t cover validation or the minimal transaction fee"}   //nolint:lll
 	ErrInsufficientAccountBalance      = &jsonrpc.Error{Code: 54, Message: "Account balance is smaller than the transaction's max_fee"}
 	ErrValidationFailure               = &jsonrpc.Error{Code: 55, Message: "Account validation failed"}
 	ErrCompilationFailed               = &jsonrpc.Error{Code: 56, Message: "Compilation failed"}

rpc/v8/transaction.go

@@ -679,8 +679,8 @@
 		return rpccore.ErrClassHashNotFound
 	case gateway.ClassAlreadyDeclared:
 		return rpccore.ErrClassAlreadyDeclared
-	case gateway.InsufficientMaxFee:
-		return rpccore.ErrInsufficientMaxFee
+	case gateway.InsufficientResourcesForValidate:
+		return rpccore.ErrInsufficientResourcesForValidate
 	case gateway.InsufficientAccountBalance:
 		return rpccore.ErrInsufficientAccountBalance
 	case gateway.ValidateFailure: