Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: starknet_estimateMessageFee #2496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 16, 2025

rpc pkg cleanup according to #2437

Reuse v6 SimulationFlag and MsgFromL1 types for v7 and v8

As i was looking into refactoring starknet_estimateMessageFee endpoint, i just found those 2 types to refactor. I don't know if we really want to refactor those, but i opened a PR in case. Let me know if we don't necessarily want to refactor those

@hudem1 hudem1 changed the title Refactor: Reuse v6 SimulationFlag and MsgFromL1 types for v7 and v8 Refactor: starknet_estimateMessageFee Feb 16, 2025
@hudem1 hudem1 mentioned this pull request Feb 16, 2025
22 tasks
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.81%. Comparing base (482b6b5) to head (bcf7f71).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v8/estimate_fee.go 33.33% 2 Missing ⚠️
rpc/v7/estimate_fee.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   73.67%   73.81%   +0.14%     
==========================================
  Files         138      138              
  Lines       16918    16900      -18     
==========================================
+ Hits        12464    12475      +11     
+ Misses       3588     3560      -28     
+ Partials      866      865       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hudem1 hudem1 added RPC JSON RPC API Refactor labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor RPC JSON RPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants