Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: starknet_estimateMessageFee #2496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8

bcf7f71
Select commit
Loading
Failed to load commit list.
Open

Refactor: starknet_estimateMessageFee #2496

Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8
bcf7f71
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 17, 2025 in 0s

73.81% (target 70.00%)

View this Pull Request on Codecov

73.81% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.81%. Comparing base (482b6b5) to head (bcf7f71).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v8/estimate_fee.go 33.33% 2 Missing ⚠️
rpc/v7/estimate_fee.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   73.67%   73.81%   +0.14%     
==========================================
  Files         138      138              
  Lines       16918    16900      -18     
==========================================
+ Hits        12464    12475      +11     
+ Misses       3588     3560      -28     
+ Partials      866      865       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.