Improve binary search #2524
Open
Improve binary search #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2524 +/- ##
==========================================
- Coverage 73.52% 73.41% -0.11%
==========================================
Files 136 136
Lines 16659 16659
==========================================
- Hits 12248 12230 -18
- Misses 3545 3556 +11
- Partials 866 873 +7 ☔ View full report in Codecov by Sentry. |
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
AnkushinDaniil
requested a deployment
to
Staging
GitHub Actions
Waiting
- Introduced `ExecutionError` enum to encapsulate different error types, including `TransactionExecutionError` and `CustomError`. - Added `SimulationError` enum to handle specific simulation-related errors such as `OutOfGas` and `ExecutionError`. - Implemented `fmt::Display` and `From` traits for `ExecutionError` and `SimulationError` to provide meaningful error messages and conversions. - Replaced the use of `anyhow::anyhow!` with structured error handling using the new error types. - Updated `execute_transaction` to use the new `ExecutionError` type. - Refactored `is_l2_gas_accounting_enabled`, `get_gas_vector_computation_mode`, `simulate_execution`, `set_l2_gas_limit`, and `extract_l2_gas_limit` functions to handle errors using the new error types.
AnkushinDaniil
force-pushed
the
daniil/improve-bs
branch
from
e9b4e42 to
3240ab7
Compare
AnkushinDaniil
added
rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Review after #2523
Fixes #2519