Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize sierra version #2525

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Exca-DK
Copy link
Contributor

@Exca-DK Exca-DK commented Feb 20, 2025

Closes #2520

$ benchstat MASTER PR
                             │    MASTER     │                 PR                 │
                             │    sec/op     │   sec/op     vs base               │
SierraVersion/pre_0.1.0-32     138.200n ± 3%   2.083n ± 1%  -98.49% (p=0.002 n=6)
SierraVersion/after_0.1.0-32    224.55n ± 1%   53.22n ± 1%  -76.30% (p=0.002 n=6)
geomean                          176.2n        10.53n       -94.02%

@Exca-DK Exca-DK force-pushed the Exca-DK/optimize-sierra-version branch from 01939d4 to e37adaa Compare February 20, 2025 00:11
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.70%. Comparing base (ba3fcff) to head (3fc39c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
+ Coverage   73.62%   73.70%   +0.07%     
==========================================
  Files         136      136              
  Lines       16774    16774              
==========================================
+ Hits        12350    12363      +13     
+ Misses       3555     3545      -10     
+ Partials      869      866       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimise felt call when getting sierra version
2 participants