Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Reuse v6 starknet_add-Invoke/DeployAccount/Declare-Transaction handler for v7 #2534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 21, 2025

rpc pkg cleanup to #2437

  • Fix a little missing validation field for the SenderAddress field inside v6 Transaction type.

  • Reuse v6 handler for v7 for starknet_addInvokeTransaction, starknet_addDeployAccountTransaction and starknet_addDeclareTransaction

@hudem1 hudem1 mentioned this pull request Feb 20, 2025
23 tasks
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (1709a05) to head (1a7ac25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
+ Coverage   73.52%   73.60%   +0.08%     
==========================================
  Files         136      136              
  Lines       16659    16529     -130     
==========================================
- Hits        12248    12166      -82     
+ Misses       3545     3501      -44     
+ Partials      866      862       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants