-
Notifications
You must be signed in to change notification settings - Fork 6
Update Project to use the Vonage Server SDK and the latest Spring Boot dependency #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @yallen011 I can pick this up, please assign me :) |
Hey @yallen011 , i have made all the changes required(Draft pr), and here are my observations/pointers-->
And one more important thing that is there any order in which these changes should be done bcz i have tried 5 times and travis build is always failing |
Hi @ng29 thank you for your contribution. I will address your questions in order for which they were asked.
|
Please refer my comment here #14 |
Java Server SDK Dependency
We have now switched over to using the Vonage branding so this project needs to use the
com.vonage
group id instead of thecom.nexmo
group id in thepom.xml
files located in the /nexmo-spring-boot-starter and /nexmo-spring-boot-autoconfig.The property name also needs to be changed from
nexmo.version
tovonage.version
which can be found at the bottom of the pom.xml file located at the root of the project.Updating Imports
Once the dependency is changed, the imports in the code that throw an error will have to be updated to
com.vonage
.Spring Boot Dependency
The Spring Boot also needs to be updated to the latest. The Spring Boot version property can be found in the
pom.xml
file at the root of the project.Once the version is updated from the root, the other pom.xml files need to be checked to make sure any other spring dependencies are using the latest version
Update
nexmo-starter
VersionUpdate nexmo-starter version to 2.2.0 in all the pom.xml files that include that dependency.
Testing
Once all imports have been made run the
mvn clean install
command make sure the project builds successfully and run the project locally to make sure it still works.Update README
Update the readme to reflect the vonage dependency and the correct version under the Customize Nexmo Client Version section
Create a new table under the current table at the bottom of the README with the following column headers Nexmo Spring Boot Starter and Vonage Java Client. The first entry should use
v2.0.0
as the Nexmo Spring Boot Starter version andv5.5.0
as the Vonage Java Client version.The text was updated successfully, but these errors were encountered: