Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: apply design qa 24.02.27 #39

Merged
merged 2 commits into from
Feb 28, 2024
Merged

style: apply design qa 24.02.27 #39

merged 2 commits into from
Feb 28, 2024

Conversation

JinleeJeong
Copy link
Member

@JinleeJeong JinleeJeong commented Feb 27, 2024 •
edited
Loading

Issue Number

close: #

작업 내역

구현 내용 및 작업 했던 내역

  • 제곧내 입니다! 27일 마무리 디자인 QA이며 토스트 디자인 수정하고, input 태그 border 통일했습니다.

변경사항

  • 의존성 목록

PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 특이 사항 1
  • 특이 사항 2

Checklist

PR 등록 전 확인할 점

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat(user): add login page)
  • assignee가 본인으로 되어있고, label은 PR 주제에 맞게 추가했는가
  • description에 PR에 대해 구체적으로 설명했는가

@JinleeJeong JinleeJeong changed the title style: apply design qa 24.02.28 style: apply design qa 24.02.27 Feb 27, 2024
@JinleeJeong JinleeJeong self-assigned this Feb 27, 2024
@JinleeJeong JinleeJeong marked this pull request as ready for review February 27, 2024 16:55
eric-jy-park
eric-jy-park approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@eric-jy-park eric-jy-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@JinleeJeong JinleeJeong merged commit 3b2f7bb into main Feb 28, 2024
@JinleeJeong JinleeJeong deleted the style/design-qa-2-28 branch February 28, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-jy-park eric-jy-park eric-jy-park approved these changes

Assignees

@JinleeJeong JinleeJeong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JinleeJeong @eric-jy-park