Skip to content

Update index.js - KCD_Xbox_Support - IDs, executable, and requiresLauncher #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChemGuy1611
Copy link
Contributor

@ChemGuy1611 ChemGuy1611 commented Feb 3, 2025

Added Xbox version support and enhanced executable and requiresLauncher functions.

Goes with #157

Added Xbox version support and enhanced executable and requiresLauncher functions.
@ChemGuy1611 ChemGuy1611 changed the title Update index.js - KCD Update index.js - KCD_Xbox_Support Feb 3, 2025
@ChemGuy1611 ChemGuy1611 changed the title Update index.js - KCD_Xbox_Support Update index.js - KCD_Xbox_Support - IDs, executable, and requiresLauncher Feb 3, 2025
@IDCs
Copy link
Contributor

IDCs commented Feb 4, 2025

Hi @ChemGuy1611, thanks for your PR - I'm afraid that I can't merge this in as the .js files are generated when compiling the .ts files. In order to compile the files, you're going to need the typescript node module - internally we always compile the typescript games alongside the Vortex build which gives us access to that module, but it also regenerates the .js files which will overwrite your changes every time we create a new Vortex build.

I suggest trying to build Vortex on your machine so that you're able to compile the typescript game extensions, and make your changes to the .ts files instead.

(this overcomplicated build process for this repo is partially the reason why we don't accept new additions anymore)

Alternatively, you can make the changes to the .ts files and I'll compile them before merging them in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants