Skip to content

Commit 8d432bd

Browse files
committed
refine the UI labeling
1 parent fd932c7 commit 8d432bd

File tree

6 files changed

+13
-8
lines changed

6 files changed

+13
-8
lines changed

frontend/js/app/nginx/access/form.ejs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<ul class="nav nav-tabs" role="tablist">
99
<li role="presentation" class="nav-item"><a href="#details" aria-controls="tab1" role="tab" data-toggle="tab" class="nav-link active show" aria-selected="true"><i class="fe fe-zap"></i> <%- i18n('access-lists', 'details') %></a></li>
1010
<li role="presentation" class="nav-item"><a href="#auth" aria-controls="tab4" role="tab" data-toggle="tab" class="nav-link" aria-selected="false"><i class="fe fe-users"></i> <%- i18n('access-lists', 'authorization') %></a></li>
11-
<li role="presentation" class="nav-item"><a href="#clients" aria-controls="tab2" role="tab" data-toggle="tab" class="nav-link" aria-selected="false"><i class="fe fe-radio"></i> <%- i18n('access-lists', 'clients') %></a></li>
11+
<li role="presentation" class="nav-item"><a href="#access" aria-controls="tab2" role="tab" data-toggle="tab" class="nav-link" aria-selected="false"><i class="fe fe-radio"></i> <%- i18n('access-lists', 'access') %></a></li>
1212
</ul>
1313

1414
<div class="tab-content">
@@ -42,8 +42,8 @@
4242
<div class="items"><!-- items --></div>
4343
</div>
4444

45-
<!-- Clients -->
46-
<div class="tab-pane" id="clients">
45+
<!-- Access -->
46+
<div class="tab-pane" id="access">
4747
<div class="clients"><!-- clients --></div>
4848
<div class="text-muted">Note that the <code>allow</code> and <code>deny</code> directives will be applied in the order they are defined.</div>
4949
</div>

frontend/js/app/nginx/access/list/item.ejs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
<td>
1515
<%- i18n('access-lists', 'item-count', {count: items.length || 0}) %>
1616
</td>
17+
<td>
18+
<%- i18n('access-lists', 'client-count', {count: clients.length || 0}) %>
19+
</td>
1720
<td>
1821
<%- i18n('access-lists', 'proxy-host-count', {count: proxy_host_count}) %>
1922
</td>

frontend/js/app/nginx/access/list/main.ejs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<thead>
22
<th width="30">&nbsp;</th>
33
<th><%- i18n('str', 'name') %></th>
4-
<th><%- i18n('users', 'title') %></th>
4+
<th><%- i18n('access-lists', 'authorization') %></th>
5+
<th><%- i18n('access-lists', 'access') %></th>
56
<th><%- i18n('proxy-hosts', 'title') %></th>
67
<% if (canManage) { %>
78
<th>&nbsp;</th>

frontend/js/app/nginx/proxy/access-list-item.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="title">
44
<i class="fe fe-lock text-teal"></i> <%- name %>
55
</div>
6-
<span class="description"><%- i18n('access-lists', 'item-count', {count: items.length || 0}) %> &ndash; Created: <%- formatDbDate(created_on, 'Do MMMM YYYY, h:mm a') %></span>
6+
<span class="description"><%- i18n('access-lists', 'item-count', {count: items.length || 0}) %>, <%- i18n('access-lists', 'client-count', {count: clients.length || 0}) %> &ndash; Created: <%- formatDbDate(created_on, 'Do MMMM YYYY, h:mm a') %></span>
77
<% } else { %>
88
<div class="title">
99
<i class="fe fe-unlock text-yellow"></i> <%- i18n('access-lists', 'public') %>

frontend/js/app/nginx/proxy/form.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ module.exports = Mn.View.extend({
222222
}
223223
},
224224
load: function (query, callback) {
225-
App.Api.Nginx.AccessLists.getAll(['items'])
225+
App.Api.Nginx.AccessLists.getAll(['items', 'clients'])
226226
.then(rows => {
227227
callback(rows);
228228
})

frontend/js/i18n/messages.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,14 @@
184184
"public": "Publicly Accessible",
185185
"public-sub": "No Access Restrictions",
186186
"help-title": "What is an Access List?",
187-
"help-content": "Access Lists provide authentication for the Proxy Hosts via Basic HTTP Authentication.\nYou can configure multiple usernames and passwords for a single Access List and then apply that to a Proxy Host.\nThis is most useful for forwarded web services that do not have authentication mechanisms built in.",
187+
"help-content": "Access Lists provide a blacklist or whitelist of specific client IP addresses along with authentication for the Proxy Hosts via Basic HTTP Authentication.\nYou can configure multiple client rules, usernames and passwords for a single Access List and then apply that to a Proxy Host.\nThis is most useful for forwarded web services that do not have authentication mechanisms built in or that you want to protect from access by unknown clients.",
188188
"item-count": "{count} {count, select, 1{User} other{Users}}",
189+
"client-count": "{count} {count, select, 1{Rule} other{Rules}}",
189190
"proxy-host-count": "{count} {count, select, 1{Proxy Host} other{Proxy Hosts}}",
190191
"delete-has-hosts": "This Access List is associated with {count} Proxy Hosts. They will become publicly available upon deletion.",
191192
"details": "Details",
192193
"authorization": "Authorization",
193-
"clients": "Clients"
194+
"access": "Access"
194195
},
195196
"users": {
196197
"title": "Users",

0 commit comments

Comments
 (0)