Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations Padding/AnchorOffset #38

Merged
merged 13 commits into from
Oct 1, 2023
Merged

Annotations Padding/AnchorOffset #38

merged 13 commits into from
Oct 1, 2023

Conversation

nikischin
Copy link
Contributor

  • Implement padding and AnchorOffset in Markers and Annotations
  • Created a new Storybook example
  • Implemented clusteringIdentifier also in Annotations not only Markers.
  • Updated support overview.

Based on my other PR #37, which should be merged before this one... Thank you!

@Nicolapps Nicolapps mentioned this pull request Sep 3, 2023
Closed
Nicolapps
Nicolapps requested changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@Nicolapps Nicolapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I have a few comments about minor details but we can merge it afterwards.

nikischin and others added 3 commits October 1, 2023 19:56
@nikischin @Nicolapps
Apply suggestions from code review
5798422 
Thank you for improving the code°

Co-authored-by: Nicolas Ettlin <nicolas.ettlin@me.com>
@nikischin
Merge branch 'main' into feature/annotationoptions
4a3f157
@nikischin
Added correct type
c3ca19e
Nicolapps
Nicolapps approved these changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@Nicolapps Nicolapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for the PR and the fixes!

@Nicolapps Nicolapps merged commit 926d06b into Nicolapps:main Oct 1, 2023
@Nicolapps Nicolapps mentioned this pull request Oct 1, 2023
Merged
@nikischin nikischin deleted the feature/annotationoptions branch October 1, 2023 22:56
@Nicolapps
Copy link
Owner

Released in mapkit-react 1.13.0 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicolapps Nicolapps Nicolapps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikischin @Nicolapps