-
Notifications
You must be signed in to change notification settings - Fork 0
build: Psl auto pr review2 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NirajC-Microsoft
wants to merge
17
commits into
main
Choose a base branch
from
psl-auto-pr-review
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
dd75ef0
Create auto pr review .yml file
NirajC-Microsoft 117a75a
Update auto-pr-review.yml
NirajC-Microsoft ba33402
Update auto-pr-review.yml
NirajC-Microsoft 09dbdbd
Updates in - Created auto pr review .yml file
NirajC-Microsoft 1b73254
Update in docker file
NirajC-Microsoft 21cacab
Changed the auto pr reviewer
NirajC-Microsoft 6f7625a
Changed the reviewer version
NirajC-Microsoft 863ab73
using omio labs as reviewer
NirajC-Microsoft d645b0b
Add config files
NirajC-Microsoft 139a6cb
Remove with block from yml
NirajC-Microsoft fd84c89
add with block in yml
NirajC-Microsoft 2ec0b05
Remove comments
NirajC-Microsoft ceb64f1
Change version of checkout actions
NirajC-Microsoft f293fc7
Add github token with 'with' block
NirajC-Microsoft 64bdcac
change pr-boat confir file format
NirajC-Microsoft 2343f2a
undo the auto-pr-bot format changes
NirajC-Microsoft bc0ccd3
change config file name
NirajC-Microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| { | ||
| "model": "gpt-4", | ||
| "commentMode": "multi", | ||
| "language": "en", | ||
| "filesToIgnore": [ | ||
| "**/*.md", | ||
| "**/*.yml", | ||
| "**/*.json", | ||
| "**/__pycache__/**", | ||
| "**/*.lock" | ||
| ], | ||
| "rules": [ | ||
| { | ||
| "name": "No TODOs in code", | ||
| "description": "Prevent merging PRs with TODO comments left in code.", | ||
| "pattern": "TODO", | ||
| "failOnMatch": true | ||
| }, | ||
| { | ||
| "name": "Avoid console/debug prints", | ||
| "description": "Remove print/debug/log statements before committing.", | ||
| "pattern": "console\\.log|print\\(|debugger;", | ||
| "failOnMatch": true | ||
| }, | ||
| { | ||
| "name": "Require tests for Python changes", | ||
| "description": "Changes to backend Python code should include tests.", | ||
| "pathPattern": "backend/**/*.py", | ||
| "requireMatchingTest": true | ||
| }, | ||
| { | ||
| "name": "Require tests for React components", | ||
| "description": "Ensure that React component changes include test coverage.", | ||
| "pathPattern": "frontend/src/components/**/*.tsx?", | ||
| "requireMatchingTest": true | ||
| }, | ||
| { | ||
| "name": "Avoid hardcoded secrets or keys", | ||
| "description": "Scan for obvious secret patterns in code.", | ||
| "pattern": "(api[_-]?key|secret|password)\\s*[:=]\\s*[\"'].*[\"']", | ||
| "failOnMatch": true | ||
| } | ||
| ] | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Auto PR Review | ||
|
|
||
| on: [pull_request] | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: omio-labs/pr-reviewer-bot@v1 | ||
| with: | ||
| GITHUB_TOKEN: ${{ secrets.GIT_TOKEN }} | ||
|
|
||
|
|
||
|
|
||
| # on: | ||
| # pull_request: | ||
| # types: [opened, edited, synchronize] | ||
|
|
||
| # jobs: | ||
| # review: | ||
| # runs-on: ubuntu-latest | ||
|
|
||
| # steps: | ||
| # - name: Checkout PR code | ||
| # uses: actions/checkout@v3 | ||
|
|
||
| # - name: Run Auto PR Review | ||
| # uses: tianhaoz95/auto-pr-review@v0.0.9 | ||
| # with: | ||
| # github-token: ${{ secrets.GIT_TOKEN }} | ||
| # I need to create new token for this repo and add it to secrets, cannot use the default GITHUB_TOKEN. | ||
| # because this token does not have permission to post reviews for PRs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -76,8 +76,8 @@ jobs: | |||||||||||||||||
| file: ./src/WebApp.Dockerfile | ||||||||||||||||||
| push: ${{ github.ref_name == 'main' || github.ref_name == 'dev' || github.ref_name == 'demo' || github.ref_name == 'dependabotchanges' }} | ||||||||||||||||||
| tags: | | ||||||||||||||||||
| ${{ steps.registry.outputs.int_registry }}/webapp:${{ steps.determine_tag.outputs.tagname }} | ||||||||||||||||||
| ${{ steps.registry.outputs.int_registry }}/webapp:${{ steps.determine_tag.outputs.tagname }}_${{ steps.date.outputs.date }}_${{ github.run_number }} | ||||||||||||||||||
| ${{ steps.registry.outputs.int_registry }} webapp:${{ steps.determine_tag.outputs.tagname }} | ||||||||||||||||||
| ${{ steps.registry.outputs.int_registry }} webapp:${{ steps.determine_tag.outputs.tagname }}_${{ steps.date.outputs.date }}_${{ github.run_number }} | ||||||||||||||||||
|
Comment on lines
+79
to
+80
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The removal of the slash between the registry and the image name may result in an invalid Docker tag format. Consider restoring the slash (/) to correctly construct the tag.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback
Comment on lines
+79
to
+80
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Docker image tag strings now have a space instead of a forward slash between the registry URL and the image name, which could result in incorrect image tagging. Consider restoring the forward slash (/) between these components.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||||||||||
|
|
||||||||||||||||||
| - name: Build Docker Image and optionally push - External Registry | ||||||||||||||||||
| if: ${{ github.ref_name == 'main' }} | ||||||||||||||||||
|
|
@@ -87,6 +87,6 @@ jobs: | |||||||||||||||||
| file: ./src/WebApp.Dockerfile | ||||||||||||||||||
| push: ${{github.ref_name == 'main' }} | ||||||||||||||||||
| tags: | | ||||||||||||||||||
| ${{ steps.registry.outputs.ext_registry }}/webapp:${{ steps.determine_tag.outputs.tagname }} | ||||||||||||||||||
| ${{ steps.registry.outputs.ext_registry }}/webapp:${{ steps.determine_tag.outputs.tagname }}_${{ steps.date.outputs.date }}_${{ github.run_number }} | ||||||||||||||||||
| ${{ steps.registry.outputs.ext_registry }} webapp:${{ steps.determine_tag.outputs.tagname }} | ||||||||||||||||||
| ${{ steps.registry.outputs.ext_registry }} webapp:${{ steps.determine_tag.outputs.tagname }}_${{ steps.date.outputs.date }}_${{ github.run_number }} | ||||||||||||||||||
|
Comment on lines
+90
to
+91
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The missing slash between the external registry and the image name could produce an improperly formatted Docker tag. Inserting a slash (/) between the registry and the image name should resolve this.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback
Comment on lines
+90
to
+91
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The tag for the external registry image appears to be missing the slash separator between the registry URL and the image name. Adding a '/' should correctly format the Docker tag.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||||||||||
|
|
||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider removing the commented-out workflow configuration if it is no longer needed to enhance clarity and maintainability.
Copilot uses AI. Check for mistakes.