Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level selection #184

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix log level selection #184

merged 1 commit into from
Jan 30, 2024

Conversation

sosthene-nitrokey
Copy link
Contributor

In #176 I wanted to allow RUST_LOG overriding the config file, but it also made the config file be always ignored when file logging was enabled

In #176  I wanted to allow
RUST_LOG overriding the config file, but it also made the config file be always ignored
when file logging was enabled
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (92f196c) 90.37% compared to head (56358b2) 90.40%.

Files Patch % Lines
pkcs11/src/config/logging.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   90.37%   90.40%   +0.03%     
==========================================
  Files          31       31              
  Lines        6627     6638      +11     
==========================================
+ Hits         5989     6001      +12     
+ Misses        638      637       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sosthene-nitrokey sosthene-nitrokey merged commit 4f987ce into main Jan 30, 2024
5 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the fix-log-level-selection branch January 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants