Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level selection #184

Merged
merged 1 commit into from
Jan 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions pkcs11/src/config/logging.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::env;
use std::path::PathBuf;

use log::{info, warn, LevelFilter};
Expand Down Expand Up @@ -162,8 +163,13 @@
}
}

let mut log_level: LevelFilter = config
.log_level
.map(Into::into)
.unwrap_or_else(log::max_level);

if use_file {
let mut builder = env_logger::Builder::from_default_env();
let mut builder = env_logger::Builder::new();

let path = &config.log_file.as_deref().unwrap_or("-".as_ref());

Expand All @@ -190,23 +196,29 @@
};
}

env_logger = Some(builder.build());
}

// RUST_LOG must override the default filter
match (env_logger.as_ref(), config.log_level.as_ref()) {
(Some(logger), Some(config_filter)) => {
log::set_max_level(logger.filter().min(LevelFilter::from(*config_filter)));
let mut override_filter = false;
if let Ok(filters) = env::var("RUST_LOG") {
builder.parse_filters(&filters);
override_filter = true;
} else if let Some(filter) = config.log_level {
builder.filter_level(filter.into());

Check warning on line 204 in pkcs11/src/config/logging.rs

View check run for this annotation

Codecov / codecov/patch

pkcs11/src/config/logging.rs#L204

Added line #L204 was not covered by tests
}
(Some(logger), _) if logger.filter() > LevelFilter::Error => {
log::set_max_level(logger.filter());

if let Ok(format) = env::var("RUST_LOG_STYLE") {
builder.parse_write_style(&format);

Check warning on line 208 in pkcs11/src/config/logging.rs

View check run for this annotation

Codecov / codecov/patch

pkcs11/src/config/logging.rs#L208

Added line #L208 was not covered by tests
}
(None, Some(level)) => {
log::set_max_level((*level).into());

let tmp = builder.build();

if override_filter {
log_level = tmp.filter();
}
_ => {}

env_logger = Some(tmp);
}

log::set_max_level(log_level);

log::set_boxed_logger(Box::new(MultiLog {
syslog_logger,
env_logger,
Expand Down
Loading