Upload build artifacts for each PR #232
Conversation
sosthene-nitrokey
force-pushed
the
windows-build-each-pr
branch
from
0dc460f to
04298b1
Compare
.github/workflows/rust-tests.yml
Outdated
| - name: Archive Artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: nethsm_pkcs11.dll |
There was a problem hiding this comment.
AFAIS this overrides the output of check-windows. Include the platform in the artifact name?
There was a problem hiding this comment.
Actually it’s also missing, but I think it would collide with the windows artifact if it would exist.
Warning: No files were found with the provided path: target/release/nethsm_pkcs11.dll. No artifacts will be uploaded.
Maybe set if-no-files-found: error?
.github/workflows/rust-tests.yml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: nethsm_pkcs11.dll | ||
| path: target/release/nethsm_pkcs11.so |
There was a problem hiding this comment.
Warning: No files were found with the provided path: target/release/nethsm_pkcs11.so. No artifacts will be uploaded.
sosthene-nitrokey
force-pushed
the
windows-build-each-pr
branch
2 times, most recently
from
9d78ee1 to
62bd587
Compare
|
Not sure if we want to merge this and build for each PR. It's mostly useful to have those builds on a specific branch when needed for testing fixes with customers (here specifically to test #231 on windows). |
|
I think it generally makes sense to always build instead of check as some errors (linking problems, errors in const contexts, ...) could be missed otherwise. I don’t have a strong opinion on whether to store the artifacts. |
This makes testing easier
sosthene-nitrokey
force-pushed
the
windows-build-each-pr
branch
from
62bd587 to
23a3979
Compare
|
If we build it makes sense to have the artifacts. I could also see the appeal of only building in the debug profile, but that could make the binaries useless even for testing. |
|
I'd prefer to have the artifacts uploded - we'll have similar situations regularly where we need the binaries built for certain changes only... |
|
Yes and being able to go back and grab a binary from before a change is also interesting. Once reviewed I'll merge. |
No description provided.