Revert "Revert "wayland: mark as broken on darwin""

[wegank]

Description of changes

tl;dr: It is a mistake to port one package to macOS while breaking tons of others.

This PR reverts #214828, which misleadingly builds a stub Wayland package on macOS (see #214828 (comment)) and causes build failures on almost all packages marked as broken transitively by Wayland before.

The issue was observed at least two weeks ago, in #212123, when the maintainer discovered that inherit (wayland.meta) platforms didn't work as intended on macOS.

cc @alyssais @figsoda

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[alyssais]

As I explained, a Wayland package on macOS is useful because of wayland-scanner (which is in the bin output, hence you not finding it in #214828 (comment)). Wayland can be built for all Unixes to provide wayland-scanner, and it is necessary to have when cross-compiling to Linux.

Indeed wayland.meta.platforms does include Darwin, but this is correct, as the package does build for Darwin and contain useful functionality. It does not include all functionality, but that's not something that meta.platforms can encode.

In spite of this, if you still think this change is the right thing to do, then I would like to suggest we ask for third opinions from my co-maintainers of the Wayland package: @primeos @codyopel.

[alyssais]

(I'm also happy to go through and fix any incorrect occurrences on wayland.meta.platforms or similar — there seem to be a few but not that many. But I'd leave it for a few days, because I'm about to PR full FreeBSD support for our Wayland package, including the libraries, and that'll make it easier to test what the actually supported platforms for each compositor are: just Linux, or Linux+FreeBSD.)

[wegank]

Indeed wayland.meta.platforms does include Darwin, but this is correct, as the package does build for Darwin and contain useful functionality. It does not include all functionality, but that's not something that meta.platforms can encode.

I'm having an unofficial full-fledged Wayland package on macOS in my repo, so doing a simple comparison, I don't agree if what betweens useful and all functionality includes the non-existence of headers in wayland.dev and libraries in wayland:

$ find result-dev/
result-dev/
result-dev//nix-support
result-dev//nix-support/propagated-build-inputs
result-dev//lib
result-dev//lib/pkgconfig
result-dev//lib/pkgconfig/wayland-scanner.pc
result-dev//share
result-dev//share/aclocal
result-dev//share/aclocal/wayland-scanner.m4

(I'm also happy to go through and fix any incorrect occurrences on wayland.meta.platforms or similar — there seem to be a few but not that many. But I'd leave it for a few days, because I'm about to PR full FreeBSD support for our Wayland package, including the libraries, and that'll make it easier to test what the actually supported platforms for each compositor are: just Linux, or Linux+FreeBSD.)

I'll be happy to test epoll-shim on macOS, if you decide to use the latest git version.

[alyssais]

I'm having an unofficial full-fledged Wayland package on macOS in my repo

That's cool! I hope you can upstream it, as that would resolve all our problems here. :)

I'll be happy to test epoll-shim on macOS, if you decide to use the latest git version.

That's exactly what I'll be doing, because the latest git commit is a build fix from me. :P

[alyssais]

I don't agree if what betweens useful and all functionality includes the non-existence of headers in wayland.dev and libraries in wayland:

I'm not entirely sure I understand what you mean here, but the headers should be built if and only if the libraries are, since otherwise the headers would be useless. The reason to have current Wayland be buildable for macOS and other Unixes is to have the wayland-scanner binary and associated .pc file available.

[alyssais]

@wegank would #214906 be an acceptable solution?

[wegank]

@wegank would #214906 be an acceptable solution?

Thanks! I've also been trying to do something similar for the last hour, realizing finally that anything I can do should go to staging. So I think I'll close this PR now in favor of yours.

[alyssais]

Cool. Glad we've got a path forward. :)