jitsi-meet: Update list of enabled Prosody modules #264400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the list of default-enabled modules in the official Jitsi Meet Prosody Docker container: https://github.com/jitsi/docker-jitsi-meet/blob/8555fe1c4a7ea434960ec61e7774f1091400d16a/prosody/rootfs/defaults/conf.d/jitsi-meet.cfg.lua#L178-L216
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
Docker image does this and it at least makes the speaker stats work in the UI (bug fix) and also is also part of the prerequirements for enabling the Whiteboard
…her Jitsi modules depend on it At least room_metadata is confirmed to not do anything unless this module is also enabled: jitsi/jitsi-meet#14001 (comment)
|
I think this PR is good now, I still have local changes for enabling the whiteboard and Secure Domain authentication with Prosody internal credentials, but I’ll save those for subsequent PRs since those are both optional extra components and at least the whiteboard requires the metadata module enabled here. |
11 tasks
|
Superseeded by #280615. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update the list of enabled extraModules and instantiated components in Prosody by the jitsi-meet service to match those default-enabled by the official Jitsi Meet Prosody Docker container: https://github.com/jitsi/docker-jitsi-meet/blob/8555fe1c4a7ea434960ec61e7774f1091400d16a/prosody/rootfs/defaults/conf.d/jitsi-meet.cfg.lua#L178-L216
Modules already enabled in the Prosody base configuration of NixOS (including “smacks”) were not included in the extraModules. This makes the speaker stats work in the UI (bug fix) and is also part of the prerequirements for the Whiteboard (which requires a bunch of further configuration). Only modules enabled in the minimal Docker image are enabled here, breakout rooms etc would require more modules and config but are not part of the base set so were not considered.The
jitsi_sessionmodule is manually enabled due to the shippedroom_metadatamissing a dependency on it – this prevented the whiteboard from working for a completely non-obvious reason and has been fixed only in latest upstream master. Some MUC configuration set in the Docker image was also carried over while I was at it, even if it doesn’t appear to change anything noticable…Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@cleeyv @ryantm
EDIT: Added component instantiations for the added modules and some minor MUC customization done by upstream. Also added workaround for missing dependency of room_metadata module on jitsi_session (upstream bug fixed in latest master).