Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossip: add missing dependencies #341182

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Sep 11, 2024

Description of changes

Supersedes #339552, fixes building Gossip after #214906

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft force-pushed the msanft/gossip/wayland-fix branch from 4573bb5 to 5c8b015 Compare September 11, 2024 11:52
@msanft msanft requested a review from Aleksanaa September 11, 2024 11:53
@Aleksanaa Aleksanaa requested a review from a team September 11, 2024 12:17
@Mastermindaxe
Copy link
Contributor

Build failed on aarch64-darwin:
build_log_pr_341182.log
Can't look into it currently, but maybe it helps

@msanft msanft force-pushed the msanft/gossip/wayland-fix branch 2 times, most recently from 29fbb5a to afac4af Compare September 11, 2024 12:45
@Mastermindaxe
Copy link
Contributor

Still fails on aarch64-darwin:
build_log_pr_341182.log
Currently in a workshop. Can build and test, but can't really focus too much on it 😅

@msanft msanft force-pushed the msanft/gossip/wayland-fix branch from afac4af to eba7787 Compare September 11, 2024 13:02
@Mastermindaxe
Copy link
Contributor

Still fails on aarch64-darwin:
build_log_pr_341182.log
This time in the fixup phase and not in the build phase. Missing command patchelf

@reckenrode
Copy link
Contributor

postFixup should be conditioned on !stdenv.isDarwin. patchelf doesn’t work with Mach-O, and that particular fixup probably isn’t needed on Darwin anyway.

@gshpychka
Copy link
Contributor

Result of nixpkgs-review pr 341182 run on aarch64-darwin 1

1 package built:
  • gossip

@msanft msanft requested a review from Aleksanaa September 12, 2024 11:50
@msanft msanft requested a review from Aleksanaa September 12, 2024 12:41
@msanft msanft force-pushed the msanft/gossip/wayland-fix branch from 528e117 to fa7001d Compare September 12, 2024 12:41
@gshpychka
Copy link
Contributor

Result of nixpkgs-review pr 341182 run on aarch64-darwin 1

1 package built:
  • gossip

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 13, 2024
@Aleksanaa Aleksanaa merged commit 497239b into NixOS:master Sep 15, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants