Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build: ModuleWithProviders needs generic type? #106

Closed
lincolnthree opened this issue Dec 2, 2019 · 1 comment
Closed

Fails to build: ModuleWithProviders needs generic type? #106

lincolnthree opened this issue Dec 2, 2019 · 1 comment

Comments

@lincolnthree
Copy link

lincolnthree commented Dec 2, 2019

Related: ionic-team/ionic-storage#177

[ng] ERROR in Failed to compile entry-point ionic-cache due to compilation errors:
[ng] node_modules/@ionic/storage/index.d.ts(5,52): error TS-996005: IonicStorageModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If this occurrence is in library code you don't control, please contact the library authors.
[ng] 

If the app has been previously built before Ionic Cache is referenced in the app.module.ts, it seems to work fine, but if the app has not previously been built, it does not seem to work, and build crashes with the above error.

Lincolns-MacBook-Pro-2:topdecked-unified lincoln$ ionic info

Ionic:

   Ionic CLI                     : 5.4.6 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.11.5
   @angular-devkit/build-angular : 0.900.0-rc.4
   @angular-devkit/schematics    : 9.0.0-next.8
   @angular/cli                  : 9.0.0-rc.4
   @ionic/angular-toolkit        : 2.0.0

Cordova:

   Cordova CLI       : 8.1.2 (cordova-lib@8.1.1)
   Cordova Platforms : not available
   Cordova Plugins   : not available

Utility:

   cordova-res : 0.6.0 (update available: 0.8.1)
   native-run  : 0.2.7 (update available: 0.2.9)

System:

   Android SDK Tools : 26.1.1 (/usr/local/share/android-sdk)
   ios-deploy        : 1.9.4
   NodeJS            : v12.3.1 (/usr/local/Cellar/node/12.3.1/bin/node)
   npm               : 6.12.0
   OS                : macOS Mojave
   Xcode             : Xcode 11.2.1 Build version 11B500

Lincolns-MacBook-Pro-2:topdecked-unified lincoln$ 


@WillPoulson
Copy link
Collaborator

@Nodonisko

This should now be resolved by #130 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants