Code Review Android

h1. Things to focus on code review:

● Easiness to understand the code (comments) ● Coding standard ● Maintainability ● Extendability ● Architecture

h2. Code review chart for Android

This chart is to be used when doing code review on either of the platforms. It is mandatory for every one to fill this chart during/after the review. Use the following scale in evaluating of the code: 1. Strongly disagree 2. Disagree 3. Neither agree nor disagree 4. Agree 5. Strongly agree *Required

Name of the reviewer *

Clarity of the code

It is easy to understand what the code does *

1
2
3
4
5

Code is well commented with javadoc *

1
2
3
4
5

Code is well commented with inline comments *

1
2
3
4
5

Code is easy to maintain and develop further * (Extendability, maintainability)

1
2
3
4
5

Free comments

Architecture

UI, controllers and models are separated * MVC architecture

1
2
3
4
5

Functionality is divided properly in to controllers * There is no large godlike controllers

1
2
3
4
5

Reading and writing of data is done in the models * Models handle the connections to local and external database

1
2
3
4
5

The application conforms with Android framework standards *

1
2
3
4
5

Free comments

Coding conventions

Code follows the coding standards specified in QA-plan * Java: http://www.oracle.com/technetwork/java/codeconvtoc-136057.html - Objective-C: http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/CodingGuidelines/CodingGuidelines.html

1
2
3
4
5

Free comments

Misc

Code review was helpful * Resulted in refactoring, fixing bugs, etc.

1
2
3
4
5

Free comments