-
Notifications
You must be signed in to change notification settings - Fork 37
Mod-specific frontend level support #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheEnbyWitch
wants to merge
8
commits into
Nukem9:development
Choose a base branch
from
TheEnbyWitch:development
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SE2Dev Decline this PR Kappa |
Why kappa |
wouldn't there be more cases for frontend to load such as through menu's? |
@DidUknowiPwn yes - and a proper fallback handler would be needed. |
@Ray1235 😏 |
The only case where it didn't work was when exiting the game. It couldn't find the d3dbsp for the mod_frontend level |
Try |
Get latest changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply allows game_mod to load a mod_frontend level instead of the regular one if one exists.
The only thing that doesn't work is when you quit a level, BO1 can't find the mod_frontend level.
Demonstration: https://www.youtube.com/watch?v=ojtoC5IeJe0