tests pass, but more should be added

Author: NullVoxPopuli

ember-classic-import-meta-glob/addon/index.js

@@ -59,14 +59,20 @@ export function importMetaGlob(glob, options, modulePath) {
   let [, ...reversedParts] = modulePath.split('/').reverse();
   let currentDir = reversedParts.reverse().join('/');
 
-  console.log({ glob, currentDir, modulePath });
   assert(
     `not a valid path. Received: '${currentDir}' from '${modulePath}'`,
     currentDir.length > 0,
   );
 
   // TODO: drop the extensions, since at runtime, we don't have them.
   let globsArray = Array.isArray(glob) ? glob : [glob];
+
+  [...globsArray].forEach((g) => {
+    let extensionless = g.replace(/\.\w{2,3}$/, '');
+
+    globsArray.push(extensionless);
+  });
+
   let fullGlobs = globsArray.map((g) => {
     return `${currentDir}/${g.replace(/^.\//, '')}`;
   });

test-app/tests/glob-test/the-test.js

@@ -4,6 +4,8 @@ import { globs as appTreeGlob } from 'test-app/glob-imports';
 
 const testTreeGlob = import.meta.glob('./from-tests/**', { eager: true });
 
+const HERE = 'test-app/tests/glob-test/the-test';
+
 module('Glob tests', function () {
   test('works from app', function (assert) {
     let keys = Object.keys(appTreeGlob);
@@ -49,57 +51,56 @@ module('Glob tests', function () {
 
   module('underlying runtime', function () {
     test('extensions are stripped and the same as without using extensions', (assert) => {
-      let a = importMetaGlob('./from-tests/**/*.js', { eager: true });
-      let b = importMetaGlob('./from-tests/**/*', { eager: true });
+      let a = importMetaGlob('./from-tests/**/*.js', { eager: true }, HERE);
+      let b = importMetaGlob('./from-tests/**/*', { eager: true }, HERE);
 
-      assert.deepEqual(a, b);
+      assert.deepEqual(Object.keys(a), Object.keys(b));
+      assert.deepEqual(Object.values(a)[0].a, Object.values(b)[0].a);
+      assert.deepEqual(Object.values(a)[1].b, Object.values(b)[1].b);
+      assert.deepEqual(Object.values(a)[2].c, Object.values(b)[2].c);
     });
 
     module('errors', function () {
       module('glob', function () {
         test('errors when trying to escape the app', function (assert) {
           assert.throws(() => {
-            importMetaGlob(
-              '../../../something',
-              { eager: true },
-              'test-app/tests/glob-test/the-test',
-            );
-          }, /not a valid path/);
+            importMetaGlob('../../../something', { eager: true }, HERE);
+          }, /Cannot have a path that escapes the app/);
         });
 
         test('errors when a sibling path tries to escape the app', function (assert) {
           assert.throws(() => {
             importMetaGlob(
               './from-tests/../../../../something',
               { eager: true },
-              'test-app/tests/glob-test/the-test',
+              HERE,
             );
           }, /Cannot have a path that escapes the app/);
         });
 
         test('invalid glob', function (assert) {
           assert.throws(() => {
-            importMetaGlob('**/*');
+            importMetaGlob('**/*', HERE);
           }, /The glob pattern must be a relative path starting with either/);
         });
       });
 
       module('options', function () {
         test('errors with incorrect options', function (assert) {
           assert.throws(() => {
-            importMetaGlob('./**/*', true);
+            importMetaGlob('./**/*', true, HERE);
           }, /the second argument to import.meta.glob must be an object/);
         });
 
         test('when passing options, cannot be empty', function (assert) {
           assert.throws(() => {
-            importMetaGlob('./**/*', {});
+            importMetaGlob('./**/*', {}, HERE);
           }, /the only supported option is 'eager'/);
         });
 
         test('when passing options, only eager is allowed', function (assert) {
           assert.throws(() => {
-            importMetaGlob('./**/*', { boop: 1 });
+            importMetaGlob('./**/*', { boop: 1 }, HERE);
           }, /the only supported option is 'eager'/);
         });
       });
@@ -110,6 +111,12 @@ module('Glob tests', function () {
             importMetaGlob('./**/*', { eager: true });
           }, /the third argument to import.meta.glob must be passed and be the module path/);
         });
+
+        test(`errors with wrong path (can't be the entrypoint)`, function (assert) {
+          assert.throws(() => {
+            importMetaGlob('../../../something', { eager: true }, 'test-app');
+          }, /not a valid path/);
+        });
       });
     });
   });