Merge pull request #579 from NullVoxPopuli/fix-keepLatest-API

fix(keepLatest): use consistent condition name

Author: NullVoxPopuli

ember-resources/src/util/keep-latest.ts

@@ -20,7 +20,7 @@ interface Options<T = unknown> {
    * keep the latest truthy value as the "return value"
    * (as determined by the `value` option's return value)
    */
-  until: () => boolean;
+  when: () => boolean;
 
   /**
    * A function who's return value will be used as the value
@@ -59,14 +59,14 @@ interface Options<T = unknown> {
  *  }
  * ```
  */
-export function keepLatest<Return = unknown>({ until, value: valueFn }: Options<Return>) {
+export function keepLatest<Return = unknown>({ when, value: valueFn }: Options<Return>) {
   return resource(() => {
     let previous: Return | undefined;
 
     return () => {
       let value = valueFn();
 
-      if (until()) {
+      if (when()) {
         return (previous = isEmpty(value) ? previous : value);
       }
 

testing/ember-app/tests/utils/keep-latest/js-test.ts

@@ -24,7 +24,7 @@ module('Utils | keepLatest | js', function (hooks) {
       });
 
       @use data = keepLatest({
-        until: () => this.request.isLoading,
+        when: () => this.request.isLoading,
         value: () => this.request.value,
       });
     }

testing/ember-app/tests/utils/keep-latest/rendering-test.gts

@@ -33,7 +33,7 @@ module('Utils | keepLatest | rendering', function (hooks) {
     render(<template>
       {{#let instance.request as |request|}}
         {{keepLatest (hash
-          until=(fn passthrough request.isLoading)
+          when=(fn passthrough request.isLoading)
           value=(fn passthrough request.value)
         )}}
       {{/let}}