Test against ember-concurrency@v3 (#868)

* Test against ember-concurrency@v3

* Create separate test apps for ember-concurrency

* Packages need unique names

* Remove mentions of ember-concurrency in the original test-app

* Add the new test-apps to the workspaces file and include them in type checking

* Update the ember-concurrency v3 tests

* Don't have turbo yet

* More config changes, both apps pass now

* How did @embroider/macros get so far behind. weird

* Lockfile!

Author: NullVoxPopuli

.changeset/config.json

@@ -14,5 +14,5 @@
   "access": "public",
   "baseBranch": "main",
   "updateInternalDependencies": "patch",
-  "ignore": ["docs", "test-app", "@nullvoxpopuli/estimate-bytes"]
+  "ignore": ["docs", "test-app", "@nullvoxpopuli/estimate-bytes", "test-app-ec-2", "test-app-ec-3"]
 }

.changeset/thin-rules-scream.md

@@ -0,0 +1,5 @@
+---
+"ember-resources": patch
+---
+
+Test against ember-concurrency@v3, and add it as an allowed peerDepnedency

.github/renovate.json5

@@ -119,6 +119,12 @@
       "matchDepTypes": ["dependencies"],
       "enabled": false
     },
+    {
+      // these apps test specific ember-concurrency versions
+      "matchPaths": ["test-app-ec-2/package.json", "test-app-ec-3/package.json"],
+      "matchDepPatterns": ["ember-concurrency"],
+      "enabled": false,
+    },
     {
       // changing engines forces other people to need to upgrade their minimum node
       // therefor engine changes are breaking changes

.github/workflows/ci.yml

@@ -69,9 +69,9 @@ jobs:
       - name: 'Type checking'
 
         run: |
-          pnpm --filter test-app exec tsc -v;
-          pnpm --filter test-app exec glint --version;
-          pnpm --filter test-app exec glint;
+          pnpm --filter "test-app*" exec tsc -v;
+          pnpm --filter "test-app*" exec glint --version;
+          pnpm --filter "test-app*" exec glint;
 
 
 
@@ -133,6 +133,26 @@ jobs:
           node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
           --skip-cleanup
 
+  test-ember-concurrency:
+    name: "w/ ${{ matrix.concurrencyVersion }}"
+    timeout-minutes: 5
+    runs-on: ubuntu-latest
+    needs: [default_tests]
+
+    strategy:
+      fail-fast: false
+      matrix:
+        concurrencyVersion:
+          - "test-app-ember-concurrency-2"
+          - "test-app-ember-concurrency-3"
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: NullVoxPopuli/action-setup-pnpm@v2
+      - uses: ./.github/actions/download-built-package
+      - name: Run Tests
+        run: pnpm test:ember
+        working-directory: ${{ matrix.concurrencyVersion }} 
 
 
   # https://github.com/changesets/action
@@ -146,6 +166,7 @@ jobs:
       - floating_tests
       - typecheck
       - try_scenarios
+      - test-ember-concurrency
 
     steps:
       - uses: actions/checkout@v3

ember-resources/package.json

@@ -109,7 +109,7 @@
     "@glimmer/tracking": "^1.1.2",
     "@glint/template": "^1.0.0-beta.3 || ^1.0.0",
     "ember-async-data": "^1.0.1",
-    "ember-concurrency": "^2.0.0",
+    "ember-concurrency": "^2.0.0 || ^3.0.0",
     "ember-source": "^3.28.0 || ^4.0.0 || ^5.0.0"
   },
   "peerDependenciesMeta": {