Skip to content

Commit 7c4b90f

Browse files
Merge pull request #1902 from NullVoxPopuli/upgrade-primitives
Update ember-primitives
2 parents b96bcb1 + 07556b9 commit 7c4b90f

File tree

6 files changed

+116
-202
lines changed

6 files changed

+116
-202
lines changed

apps/repl/app/routes/application.ts

+9-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
import Route from '@ember/routing/route';
2-
import { service } from '@ember/service';
32

4-
import type { SetupService } from 'ember-primitives';
3+
import { setupTabster } from 'ember-primitives/tabster';
4+
5+
const map = new WeakSet();
56

67
export default class ApplicationRoute extends Route {
7-
@service('ember-primitives/setup') declare primitives: SetupService;
8+
// The router is littered with bugs.. so here we only let the model hook run once per instance
9+
model() {
10+
if (!map.has(this)) {
11+
setupTabster(this);
12+
map.add(this);
13+
}
814

9-
async beforeModel() {
10-
this.primitives.setup();
1115
document.querySelector('#initial-loader')?.remove();
1216
}
1317
}

apps/repl/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@
152152
"ember-element-helper": "^0.8.5",
153153
"ember-focus-trap": "^1.1.1",
154154
"ember-modifier": "^4.2.0",
155-
"ember-primitives": "^0.23.1",
155+
"ember-primitives": "^0.27.2",
156156
"ember-repl": "workspace:*",
157157
"ember-resize-observer-service": "^1.1.0",
158158
"ember-resources": "^7.0.3",
@@ -162,6 +162,7 @@
162162
"html-to-image": "^1.11.13",
163163
"kolay": "^3.0.0",
164164
"limber-ui": "workspace:*",
165+
"tabster": "8.2.0",
165166
"lz-string": "^1.5.0",
166167
"path-browserify": "^1.0.1",
167168
"penpal": "^6.2.2",

apps/tutorial/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"@universal-ember/kolay-ui": "^0.0.13",
4242
"ember-async-data": "1.0.3",
4343
"ember-modifier": "^4.2.0",
44-
"ember-primitives": "^0.23.1",
44+
"ember-primitives": "^0.27.2",
4545
"ember-resources": "^7.0.3",
4646
"ember-route-template": "^1.0.3",
4747
"kolay": "^3.0.0",

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
"ember-get-config": "github:mansona/ember-get-config#config-meta-loader",
5656
"ember-auto-import": "^2.9.0",
5757
"ember-repl": "workspace:*",
58+
"ember-primitives": "^0.27.2",
5859
"ember-source": ">= 6.4.0-alpha.3",
5960
"array-includes": "npm:@nolyfill/array-includes@^1",
6061
"array.prototype.findlastindex": "npm:@nolyfill/array.prototype.findlastindex@^1",

packages/app-support/limber-ui/addon/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"ember-async-data": "1.0.3",
7878
"ember-cli-htmlbars": "^6.3.0",
7979
"ember-modifier": "^4.2.0",
80-
"ember-primitives": "^0.23.1",
80+
"ember-primitives": "^0.27.2",
8181
"ember-resources": "^7.0.3",
8282
"ember-source": ">= 6.4.0-alpha.3",
8383
"ember-template-imports": "^4.3.0",

0 commit comments

Comments
 (0)