Skip to content

Commit 9b701cb

Browse files
committed
update
1 parent f15455d commit 9b701cb

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/deploy-preview.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,12 @@ jobs:
136136
header: preview-urls
137137
number: ${{ github.event.workflow_run.pull_requests[0].number }}
138138
message: |+
139-
| Project | Preview URL |
139+
| Project | Preview URL[^note] |
140140
| ------- | ----------- |
141-
| Limber | https://${{ github.event.workflow_run.head_sha }}.limber-glimdown.pages.dev |
142-
| Tutorial | https://${{ github.event.workflow_run.head_sha }}.limber-glimmer-tutorial.pages.dev |
141+
| Limber | https://${{ github.event.workflow_run.head_branch }}.limber-glimdown.pages.dev |
142+
| Tutorial | https://${{ github.event.workflow_run.head_branch }}.limber-glimmer-tutorial.pages.dev |
143143
144144
[Logs](https://github.com/NullVoxPopuli/limber/actions/runs/${{ github.run_id }})
145+
146+
[^note]: if these branch preview links are not working, please check the logs for the commit-based preview link. There is a character limit of 28 for the branch subdomain, as well as some other heuristics, [described here](https://community.cloudflare.com/t/algorithm-to-generate-a-preview-dns-subdomain-from-a-branch-name/477633?u=walshymvp) for the sake of implementation ease in deploy-preview.yml, that algo has been omitted. The URLs are logged in the wrangler output, but it's hard to get outputs from a matrix job.
147+

0 commit comments

Comments
 (0)