Merge pull request #1905 from NullVoxPopuli/improve-share-dialog

Improve share dialog

Author: NullVoxPopuli

apps/repl/app/components/limber/share.css

@@ -68,10 +68,21 @@ button[data-share-button] {
   }
 }
 dialog.preem {
-  border-radius: 0.25rem;
+  width: 100dvw;
+  background: transparent;
+  display: flex;
+  justify-content: center;
+  overflow: hidden;
+
   animation: var(--animation-slide-in-up), var(--animation-fade-in);
   animation-timing-function: var(--ease-out-5);
   animation-duration: 0.2s;
+
+  > .modal-facade {
+    background: white;
+    border-radius: 0.25rem;
+    width: max-content;
+  }
 }
 dialog.preem::backdrop {
   backdrop-filter: blur(1px);

apps/repl/app/components/limber/share.gts

@@ -33,17 +33,19 @@ export const Share = <template>
     </button>
 
     <m.Dialog class="preem" {{focusTrap isActive=m.isOpen}}>
+      <SaveBanner @isShowing={{isShowing.current}} />
+
       {{#if m.isOpen}}
-        <ShareModal @onCancel={{m.close}} />
+        <div class="modal-facade">
+          <ShareModal @onCancel={{m.close}} />
+        </div>
       {{/if}}
     </m.Dialog>
   </Modal>
 </template>;
 
 class ShareModal extends Component<{ onCancel: () => void }> {
   <template>
-    <SaveBanner @isShowing={{isShowing.current}} />
-
     <header><h2>Share</h2>
       <FlatButton {{on "click" @onCancel}} aria-label="close this share modal">
         <FaIcon @size="xs" @icon={{faXmark}} class="aspect-square" />
@@ -127,8 +129,17 @@ class ShareModal extends Component<{ onCancel: () => void }> {
 
     try {
       await this.toClipboard();
-    } catch {
-      // TODO: Toast message
+    } catch (e) {
+      if (typeof e === 'object' && e !== null) {
+        if ('message' in e && typeof e.message === 'string') {
+          this.error = e.message;
+
+          return;
+        }
+      }
+
+      console.error(e);
+      this.error = `An unknown error occurred. Details in the console. If you have time, a bug report would be appreciated <3`;
     }
   };
 }