Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Arg Components #1680

Conversation

MichalBryxi
Copy link
Contributor

@MichalBryxi MichalBryxi commented Mar 3, 2024

  • Adding the description article to discuss the contents and what are the other reasonable use-cases. Happy to expand the exercises if this is the right direction.
  • I think this nicely shows the <@foo /> pattern from here.
  • Also follows-up on the Discord conversataion.

Summary

  • I was unsure if this pattern was possible, but it is and I think there is no good understanding for folks that they can do this.
  • So expanding on the topic here.

- Adding the description article to discuss the contents and what are the other reasonable use-cases.
Copy link

stackblitz bot commented Mar 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NullVoxPopuli
Copy link
Owner

Happy to expand the exercises if this is the right direction.

I would say so! nice work! that second example is really good (good to have both tho), thanks for coming up with that!

@MichalBryxi
Copy link
Contributor Author

MichalBryxi commented Mar 4, 2024

  • Added link to docs. Plus minus. It's not exactly the topic, but covers said syntax.
  • Added exercise:
    • It combines simple passing down of the components and yielded components.
    • It's a bit verbose, but I did not want to introduce even more patterns. The only one "extra" here is yield.
    • Also added comment to make sure what is the assignment.

@NullVoxPopuli
Copy link
Owner

looks good! thank you!!!

@NullVoxPopuli NullVoxPopuli merged commit 9641094 into NullVoxPopuli:main Mar 4, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Mar 4, 2024
@NullVoxPopuli NullVoxPopuli added the documentation Improvements or additions to documentation label Mar 10, 2024
@NullVoxPopuli NullVoxPopuli mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants