Tutorial navigation selected state #1904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1877
The
Selection
component shows the select/optgroup/options for all the tutorials. It gets the data to render the options from thegrouped
property of theDocsService
and calls thetransitionTo
method on theRouterService
when a tutorial is selected.When rendering each
option
, theselected
attribute was not taking into account the group, so it was comparing the tutorial path part with the full current path and they would never match.This PR updates the
isSelected
helper so it accepts both the group and tutorial.I also added some component tests that use mocks for the two injected services.