Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete mirnao #789

Merged
merged 2 commits into from
Feb 26, 2020
Merged

obsolete mirnao #789

merged 2 commits into from
Feb 26, 2020

Conversation

cmungall
Copy link
Contributor

As per #546, we have had no working home page or download or PURL for this for a number of years

@rvita
Copy link
Contributor

rvita commented Dec 14, 2018

Pantelis Topalis replied to my request for an owner for mirnao and did not indicated that it should be obsoleted. he gave me the license info that I updated for it. I am in the process of finishing up (today, right now) the remaining metadata info that I obtained as part of the OBO services grant.

@cmungall
Copy link
Contributor Author

If it's not obsolete then it needs to be resolvable, I am happy to help Pantelis set up a github repo

@cmungall
Copy link
Contributor Author

This still does not resolve, it should be obsoleted

@rvita
Copy link
Contributor

rvita commented Apr 26, 2019

Pantelis Topalis topalis@imbb.forth.gr is the person who was giving me info on mirnao and agreed to be its contact person. I cannot find him on github to link to this ticket.

@matentzn
Copy link
Contributor

matentzn commented Aug 5, 2019

@rvita What should be done about this PR?

@bpeters42
Copy link
Contributor

bpeters42 commented Aug 6, 2019 via email

@rvita
Copy link
Contributor

rvita commented Aug 6, 2019

I still do not think it should be obsoleted if someone claimed it and is actively answering questions about it. there are still many ontologies that do not have their complete set of metadata (including many that have not yet been contacted - I am doing them in batches) and this is just one of them. Maybe we need to decide upon a time frame that each ontology must become compliant in once it has been contacted with specific missing requirements before it is deemed orphaned or obsoleted? My understanding was they would get a validation report initially? I never told Pantelis that there was a due date.

@bpeters42
Copy link
Contributor

bpeters42 commented Aug 6, 2019 via email

@jamesaoverton
Copy link
Member

I emailed topalis@imbb.forth.gr, cc @cmungall, offering to help migrate to GitHub, and asked for a reply within two weeks. If we don't hear back, we'll mark this as obsolete.

@rvita
Copy link
Contributor

rvita commented Feb 25, 2020

I emailed topalis@imbb.forth.gr In July and in Aug 2019 about this topic and he never responded. Based on his answer for IDOMAL, I think you can go ahead & obsolete. The only other contact I could find for mirnao was Vicky Dritsou who was stated to be no longer working on it byPantelis.

@jamesaoverton
Copy link
Member

I received a reply saying that we should obsolete, so I'm going to merge this.

Do we have any interest in salvaging the OWL file and putting it somewhere?

@althonos
Copy link
Member

I know that there is no real schema for the ontologies.yml file, but until now all ontologies had an activity_status. This PR removed it for mirnao, but for consistency it should still have activity_status; inactive (or activity_status: orphaned) I assume.

@jamesaoverton
Copy link
Member

Thanks @althonos! I reinserted activity_status: inactive here cf47685.

This was my oversight, and the validation didn't catch it.

We do have schemas for several fields, including activity_status here util/schema/. However when is_obsolete is true we don't apply most of those schemas, see validate-metadata.py.

We have an issue for better documenting activity status and obsolete #1126, and this is the general issue for schemas #663. I'll make a note about this specific problem on #663.

@althonos
Copy link
Member

althonos commented Feb 28, 2020

@jamesaoverton : thanks !

I'm trying to maintain a Rust library to deserialize the ontologies.yml, and it's quite strict, so that's how I catch these kind of issues. Good to know that obsolete ontologies are not required to have all fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants