Skip to content

Commit

Permalink
[FIX] account_reconcile_oca: Avoiding the singleton error related to …
Browse files Browse the repository at this point in the history
…_get_reconcile_line()

Example use case:
 File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 541, in _compute_reconcile_data_info
    record.reconcile_data_info = record._default_reconcile_data(
  File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 698, in _default_reconcile_data
    reconcile_auxiliary_id, lines = self._get_reconcile_line(
  File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 1164, in _get_reconcile_line
    new_vals = super()._get_reconcile_line(
  File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_reconcile_abstract.py", line 49, in _get_reconcile_line
    original_amount = amount = net_amount = line.debit - line.credit
  File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1154, in __get__
    record.ensure_one()
  File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5204, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: account.move.line(208, 211, 212)

TT55221
  • Loading branch information
victoralmau committed Feb 26, 2025
1 parent d2623dd commit f9341ae
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions account_reconcile_oca/models/account_bank_statement_line.py
Original file line number Diff line number Diff line change
Expand Up @@ -684,13 +684,16 @@ def _default_reconcile_data(self, from_unreconcile=False):
reconciled_line.move_id.journal_id
== self.company_id.currency_exchange_journal_id
):
reconcile_auxiliary_id, lines = self._get_reconcile_line(
reconciled_line.move_id.line_ids - reconciled_line,
"other",
from_unreconcile=False,
move=True,
)
data += lines
for rl_item in (
reconciled_line.move_id.line_ids - reconciled_line
):
reconcile_auxiliary_id, lines = self._get_reconcile_line(

Check warning on line 690 in account_reconcile_oca/models/account_bank_statement_line.py

View check run for this annotation

Codecov / codecov/patch

account_reconcile_oca/models/account_bank_statement_line.py#L690

Added line #L690 was not covered by tests
rl_item,
"other",
from_unreconcile=False,
move=True,
)
data += lines

Check warning on line 696 in account_reconcile_oca/models/account_bank_statement_line.py

View check run for this annotation

Codecov / codecov/patch

account_reconcile_oca/models/account_bank_statement_line.py#L696

Added line #L696 was not covered by tests
continue
partial = partial_lines.filtered(
lambda r, line=reconciled_line: r.debit_move_id == line
Expand Down

0 comments on commit f9341ae

Please sign in to comment.