[15.0][FIX] account_reconciliation_widget: Don't link counterpart to the stamement line #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amement line Steps to reproduce the problem: - Issue an invoice. - Add a bank statement for paying such invoice. - Reconcile the statement with the invoice. It gets paid. - Revert reconciliation from the statement. - Go again to reconcile the statement line. Expected behavior: The invoice is available to be reconciled again. Current behavior: The invoice is not available. That's because the move line of the AR/AP account was linked to the statement line in the reconciliation process through the field `statement_line_id`. That field is used for linking the generated move lines to the generating statement line, not for other things. This is probably a bad migration from v13 original code to v14, where the reconciliation and the datamodel changed. It includes a migration script that mitigates a bit the problem on past reconciled invoices, removing such link. It doesn't cover other AR/AP lines, but at least we keep data consistent for these ones. TT46644
pedrobaeza
requested review from
alexis-via,
victoralmau,
chienandalu and
luc-demeyer
chienandalu
approved these changes
Dec 27, 2023
victoralmau
approved these changes
Jan 2, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at eb29757. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-fix-account_reconciliation_widget-stml_link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the problem:
Expected behavior: The invoice is available to be reconciled again.
Current behavior: The invoice is not available.
That's because the move line of the AR/AP account was linked to the statement line in the reconciliation process through the field
statement_line_id. That field is used for linking the generated move lines to the generating statement line, not for other things.This is probably a bad migration from v13 original code to v14, where the reconciliation and the datamodel changed.
It includes a migration script that mitigates a bit the problem on past reconciled invoices, removing such link. It doesn't cover other AR/AP lines, but at least we keep data consistent for these ones.
TT46644