Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16][account_move_base_import] add hook for commission amount calculation #632

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions account_move_base_import/models/account_journal.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,17 @@
)
return vals_list

def _get_global_commission_amount(self, parser):
global_commission_amount = 0.0
commmission_field = parser.commission_field
if commmission_field:
for row in parser.result_row_list:
global_commission_amount += float(row.get(commmission_field, "0.0"))
# If commission amount is positive in field, inverse the sign
if parser.commission_sign == "+":
global_commission_amount = -global_commission_amount

Check warning on line 154 in account_move_base_import/models/account_journal.py

View check run for this annotation

Codecov / codecov/patch

account_move_base_import/models/account_journal.py#L154

Added line #L154 was not covered by tests
return global_commission_amount

def _get_extra_move_line_vals_list(self, parser, move):
"""Insert extra lines after the main statement lines.

Expand All @@ -156,15 +167,8 @@
statement ID
:param: context: global context
"""
global_commission_amount = 0
commmission_field = parser.commission_field
vals_list = []
if commmission_field:
for row in parser.result_row_list:
global_commission_amount += float(row.get(commmission_field, "0.0"))
# If commission amount is positive in field, inverse the sign
if parser.commission_sign == "+":
global_commission_amount = -global_commission_amount
global_commission_amount = self._get_global_commission_amount(parser)
partner_id = self.partner_id.id
# Commission line
if global_commission_amount > 0.0:
Expand Down
Loading