[16.0][FIX]account_statement_base: add form view for bank statement and related fixes #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexis-via, |
… default journal id for bank statement lines and fix compute of internal index for bank statement lines Removed unwanted field from view
ByteMeAsap
force-pushed
the
16.0-fix-account_statement_base
branch
from
a91b189 to
9754d03
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add form view for bank statement to pass default journal id for bank statement lines and fix compute of internal index for bank statement lines.
This PR aims to resolve 2 issues:
One is it resolves the issue coming up when trying to add new bank statement line from bank statement form view.
Secondly, it passes the journal id from statement to statement lines which otherwise would cause issues