[16.0][FIX] account_reconcile_oca: KeyError on data

[thomaspaulb]

I'm not quite sure if this is the proper solution to the below problem:

RPC_ERROR

  File "/home/ubuntu/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 456, in _compute_reconcile_data_info
    record.reconcile_data_info = record._default_reconcile_data(
  File "/home/ubuntu/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 570, in _default_reconcile_data
    self.reconcile_bank_line()
  File "/home/ubuntu/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 595, in reconcile_bank_line
    self._prepare_reconcile_line_data(self.reconcile_data_info["data"])
KeyError: 'data'

[OCA-git-bot]

Hi @etobella,
some modules you are maintaining are being modified, check this out!

[thomaspaulb]

@victoralmau Looks like this got introduced with #762

[victoralmau]

Please, can you indicate the steps to reproduce the error?

[thomaspaulb]

@victoralmau It happens in cases where reconcile_data_info is (still) an empty dictionary. Then, the account bank statement line is clicked in the reconciliation widget and you get this error, because the default value is not filled yet but it is already trying to reconcile.

In Odoo Shell I've noticed that it happens already when trying to read such bank statement lines. However on second read of the same record, the error does not happen anymore because at that moment the default is already written and the data key has become filled.

[pedrobaeza]

But isn't that something that indicates that the problem is that the default should be set from the beginning instead of just silencing/bypassing the error?

[victoralmau]

I have not found the use case that I can functionally reproduce (important to clarify), but the fix seems to be enough to avoid the error.

[thomaspaulb]

If I get time I can try to reproduce in a unit test

[alexis-via]

I also had this crash

[alexis-via]

/ocabot merge minor

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-777-by-alexis-via-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 521a52c. Thanks a lot for contributing to OCA. ❤️