Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_partner_reconcile #791

Merged
merged 36 commits into from
Feb 14, 2025
Merged

[16.0][MIG] account_partner_reconcile #791

merged 36 commits into from
Feb 14, 2025

Conversation

yibudak
Copy link

@yibudak yibudak commented Jan 30, 2025

Hello everyone,

This PR migrates the account_partner_reconcile module to the 16.0 branch. Things I've done:

  • Since the reconcile widget is no longer part of Odoo CE, this module now depends on the account_reconcile_oca module.
  • Some improvements in tests to make sure buttons open the right target.

JordiBForgeFlow and others added 30 commits January 30, 2025 08:03
@JordiBForgeFlow @yibudak
account_payment_partner_reconcile
5533232
@MiquelRForgeFlow @yibudak
[MIG] account_partner_reconcile: Migration to 10.0
b460abc
@yibudak
[MIG] account_partner_reconcile: Migration to 11.0
c3609c8
@JordiBForgeFlow @yibudak
account_partner_reconcile: change user group
ca2e452
@oca-travis @yibudak
[UPD] Update account_partner_reconcile.pot
46f2f26
@bjeficent @yibudak
[MIG] account_partner_reconcile: Migration to 12.0
934c169
@JordiBForgeFlow @yibudak
[IMP] account_partner_reconcile: splits the button 'Match payments'
edd2391 
Splits the button 'Match payments' to 'Match Receivables' and 'Match Payables', as the previous button was just now working.
@OCA-git-bot @yibudak
[UPD] README.rst
53e102d
@oca-travis @yibudak
[UPD] Update account_partner_reconcile.pot
3996e47
@LuqueDaniel @yibudak
Added translation using Weblate (Spanish)
018a8b0
@MiquelRForgeFlow @yibudak
[IMP] account_partner_reconcile: black, isort, prettier
5637970
@MiquelRForgeFlow @yibudak
[MIG] account_partner_reconcile: Migration to 13.0
b852de7
@oca-travis @yibudak
[UPD] Update account_partner_reconcile.pot
c9a483b
@OCA-git-bot @yibudak
[UPD] README.rst
b755f47
@jcoux @yibudak
[MIG] account_partner_reconcile: Migration to 14.0
9d248f1
@oca-travis @yibudak
[UPD] Update account_partner_reconcile.pot
6ed3bc5
@OCA-git-bot @yibudak
[UPD] README.rst
29536b0
@pedrocs-exo @yibudak
Added translation using Weblate (Portuguese)
2ed2c48
@pedrocs-exo @yibudak
Translated using Weblate (Portuguese)
9f4196e 
Currently translated at 100.0% (6 of 6 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_partner_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_partner_reconcile/pt/
@Yvesldff @yibudak
Added translation using Weblate (French (France))
28e1194
@Yvesldff @yibudak
Added translation using Weblate (French)
d11641f
@Yvesldff @yibudak
Translated using Weblate (French (France))
ee4ec3d 
Currently translated at 66.6% (4 of 6 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_partner_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_partner_reconcile/fr_FR/
@Yvesldff @yibudak
Translated using Weblate (French)
870c2b2 
Currently translated at 66.6% (4 of 6 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_partner_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_partner_reconcile/fr/
@ibuioli @yibudak
Added translation using Weblate (Spanish (Argentina))
3d95dfd
@ibuioli @yibudak
Translated using Weblate (Spanish (Argentina))
6834b8b 
Currently translated at 100.0% (6 of 6 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_partner_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_partner_reconcile/es_AR/
@JasminSForgeFlow @yibudak
[IMP] account_partner_reconcile: black, isort, prettier
5fd9264
@JasminSForgeFlow @yibudak
[MIG] account_partner_reconcile: Migration to 15.0
617f701
@yibudak
[UPD] Update account_partner_reconcile.pot
97acffd
@OCA-git-bot @yibudak
[UPD] README.rst
4ae28d3
@oca-transbot @yibudak
Update translation files
c3ba8a5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-15.0/account-reconcile-15.0-account_partner_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-15-0/account-reconcile-15-0-account_partner_reconcile/
OCA-git-bot and others added 5 commits January 30, 2025 08:04
@OCA-git-bot @yibudak
[UPD] README.rst
67425b3
@weblate @yibudak
Update translation files
0d50123 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-15.0/account-reconcile-15.0-account_partner_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-15-0/account-reconcile-15-0-account_partner_reconcile/
@hhgabelgaard @yibudak
Added translation using Weblate (Danish)
3218096
@hhgabelgaard @yibudak
Translated using Weblate (Danish)
c9e9596 
Currently translated at 100.0% (3 of 3 strings)

Translation: account-reconcile-15.0/account-reconcile-15.0-account_partner_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-15-0/account-reconcile-15-0-account_partner_reconcile/da/
@yibudak
[IMP] account_partner_reconcile: pre-commit stuff
fc246bc
@yibudak
Copy link
Author

yibudak commented Jan 30, 2025

@pedrobaeza

@pedrobaeza
Copy link
Member

I don't use this module, but I tag it for others to review:

/ocabot migration account_partner_reconcile

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 30, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 30, 2025
Open
5 tasks
@yibudak
Copy link
Author

yibudak commented Jan 30, 2025

@lk-eska @JordiBForgeFlow

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 30, 2025
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, LGTM

@yibudak yibudak force-pushed the 16.0-mig-account_partner_reconcile branch from f59b0ab to 7b89e42 Compare January 30, 2025 10:41
@yibudak yibudak force-pushed the 16.0-mig-account_partner_reconcile branch from 7b89e42 to 0424df0 Compare January 30, 2025 10:44
JordiMForgeFlow
JordiMForgeFlow approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍🏼

@lk-eska
Copy link
Contributor

lk-eska commented Jan 30, 2025

a future improvement would be the auto-reconcile functionality (like in enterprise)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AlexPForgeFlow
AlexPForgeFlow approved these changes Feb 5, 2025
View reviewed changes
Copy link

@AlexPForgeFlow AlexPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review!

etobella
etobella approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-791-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d1a097a into OCA:16.0 Feb 14, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 93b5cc7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@etobella etobella etobella approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@AlexPForgeFlow AlexPForgeFlow AlexPForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.