Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_reconcile_oca: improve visibility of partner on bank statement line #794

Conversation

alexis-via
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@alexis-via
Copy link
Contributor Author

BEFORE

before_rec_oca

AFTER

after_rec

Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a good idea to me

@pedrobaeza
Copy link
Member

It should be checked what happens with large partner names. If they are stripped, this change is not valid.

@alexis-via alexis-via force-pushed the 16-imp-account_reconcile_oca-usability_partner_badge branch from fa007f4 to 799687f Compare February 14, 2025 15:11
@alexis-via
Copy link
Contributor Author

No pb with long names:

long_name

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 14, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fw-port it to 17

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-794-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 3e368f7 into OCA:16.0 Feb 14, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e80a9a3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants