[18.0][MIG] account_move_base_import: migration to 18.0 #797

Ricardoalso · 2025-02-11T14:29:40Z

No description provided.

Force import partner on account.move

…o v10

…be completed manually

…eed to fill all computed and related field

…econciled to false to avoid having a null value instead

When importing a batch for a journal which has a currency different from the company currency, the values in the batch files are in the currency of the journal. The previous code was creating move lines as if the amounts in the batch file were in the company currency. We fix this by checking for the case, and converting the amounts the company currency at the rate of the date of the transaction to fill in the credit / debit columns, and setting the value of amount_currency to the value in the batch file.

Currently translated at 37.9% (41 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/

Currently translated at 100.0% (108 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/es/

Currently translated at 0.9% (1 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/fr/

Currently translated at 100.0% (108 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/es/

Currently translated at 20.3% (22 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/ca/

Currently translated at 11.1% (12 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/it/

Currently translated at 100.0% (108 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/

…e custom logic (multiple commission fields for instance)

Currently translated at 100.0% (107 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/sv/

Currently translated at 21.4% (23 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/ca/

Currently translated at 39.2% (42 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/it/

Currently translated at 100.0% (107 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/

victorvermot · 2025-02-11T17:33:27Z

account_move_base_import/wizard/import_statement_view.xml

@@ -11,7 +11,6 @@
                        domain="[('used_for_import', '=', True)]"
                    />
                    <field name="input_statement" filename="file_name" />
-                    <field name="file_name" invisible="1" />


You sure about this one ? It won't fail because it does not find file_name in view ?

Based on the migration documentation for V18

Missing fields used in domains and other attributes are added to the view as invisible automatically. If you encounter fields in views with invisible="True", they can probably be removed. Reference: odoo/odoo#137031

I am not familiar with this module but in the runbot it seams to work like expected

Oh I missed this one in the V18 doc, thanks for pointing it out !

ivantodorovich · 2025-02-12T11:37:41Z

account_move_base_import/models/account_journal.py

+                "Move %(move_name)s have been imported with %(num_lines)s " "lines."
+            )
+            % {"move_name": move.name, "num_lines": num_lines}


Suggested change

"Move %(move_name)s have been imported with %(num_lines)s " "lines."

)

% {"move_name": move.name, "num_lines": num_lines}

"Move %(move_name)s have been imported with %(num_lines)s lines.",

move_name=move.name,

num_lines=num_lines,

)

nitpicking

OCA-git-bot · 2025-02-16T15:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

houssine78

LGTM

mdietrichc2c and others added 30 commits February 11, 2025 14:45

Remane import modules

0232635

Rename last values

d919128

Corrections

775d731

Remove last mentions of statement

2e5b2b2

Rename menu + add roadmap in readme

dba6907

Rename many2many table

0571f8f

Only set account_id if not set by parser

6303cd5

Add amount_residual for reconciliation later on

bb7f6ed

Handle multi move in parser

00a140d

Add option on journal to create one or two counterparts automatically

c769060

Correct sign for debit amount

6c79f42

invalidate cache after move sql insert

3007f86

Correct error messages

ec83661

[MIG] Make modules uninstallable

7d43442

[MIG] Rename manifest files

76c7232

Force import partner on account.move (OCA#157)

0d7758a

Force import partner on account.move

Start work to port account_move_base_import and base_transaction_id t…

a88466e

…o v10

convert_to_column() seems to be the replacement of _symbol_set() in v10

feef09f

Remove print

c8bfc9a

update tests

085a5f5

update test call

7d08548

[IMP] add filter for filtering the uncompleted move line that should …

bfafc4c

…be completed manually

[FIX] add all missing field, as orm is bypassed for perf reason, we n…

3765f23

…eed to fill all computed and related field

[IMP] assert that move is balanced, recompute amount total, and set r…

b76a378

…econciled to false to avoid having a null value instead

[ADD] icon.png

a6a32a2

[FIX] remove en.po that was erroneously created by transbot

1ab93ec

remove obsolete .pot files [ci skip]

2a693dd

[UPD] Update account_move_base_import.pot

fafdc6b

[UPD] Update account_move_base_import.pot

015ee50

adrianojprado and others added 16 commits February 11, 2025 14:56

[UPD] Update account_move_base_import.pot

a2eb341

[UPD] README.rst

10a628f

[UPD] Update account_move_base_import.pot

7137642

[IMP] Add a hook to compute commission to allow submodules to add som…

eefb379

…e custom logic (multiple commission fields for instance)

[IMP] account_move_base_import: pre-commit auto fixes

97c6317

Ricardoalso force-pushed the 18.0-mig-account_move_base_import branch from babc52c to 9892aa5 Compare February 11, 2025 14:36

Ricardoalso marked this pull request as draft February 11, 2025 15:03

Ricardoalso marked this pull request as ready for review February 11, 2025 15:05

Ricardoalso force-pushed the 18.0-mig-account_move_base_import branch 3 times, most recently from 05ec25e to 6a0582e Compare February 11, 2025 16:20

[MIG] account_move_base_import: Migration to 18.0

cefbed8

Ricardoalso force-pushed the 18.0-mig-account_move_base_import branch from 6a0582e to cefbed8 Compare February 11, 2025 16:24

victorvermot approved these changes Feb 11, 2025

View reviewed changes

ivantodorovich approved these changes Feb 12, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 12, 2025

houssine78 approved these changes Feb 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] account_move_base_import: migration to 18.0 #797

[18.0][MIG] account_move_base_import: migration to 18.0 #797

Ricardoalso commented Feb 11, 2025

victorvermot Feb 11, 2025

Ricardoalso Feb 11, 2025

victorvermot Feb 12, 2025

ivantodorovich Feb 12, 2025

OCA-git-bot commented Feb 16, 2025

houssine78 left a comment

-                "Move %(move_name)s have been imported with %(num_lines)s " "lines."
-            )
-            % {"move_name": move.name, "num_lines": num_lines}
+                "Move %(move_name)s have been imported with %(num_lines)s lines.",
+                move_name=move.name,
+                num_lines=num_lines,
+            )

[18.0][MIG] account_move_base_import: migration to 18.0 #797

Are you sure you want to change the base?

[18.0][MIG] account_move_base_import: migration to 18.0 #797

Conversation

Ricardoalso commented Feb 11, 2025

victorvermot Feb 11, 2025

Choose a reason for hiding this comment

Ricardoalso Feb 11, 2025

Choose a reason for hiding this comment

victorvermot Feb 12, 2025

Choose a reason for hiding this comment

ivantodorovich Feb 12, 2025

Choose a reason for hiding this comment

OCA-git-bot commented Feb 16, 2025

houssine78 left a comment

Choose a reason for hiding this comment