[16.0][FIX] account_reconcile_oca: Avoiding the singleton error related to _get_reconcile_line() #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_get_reconcile_line()
Example use case:
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 541, in _compute_reconcile_data_info
record.reconcile_data_info = record._default_reconcile_data(
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 698, in _default_reconcile_data
reconcile_auxiliary_id, lines = self._get_reconcile_line(
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py", line 1164, in _get_reconcile_line
new_vals = super()._get_reconcile_line(
File "/opt/odoo/auto/addons/account_reconcile_oca/models/account_reconcile_abstract.py", line 49, in _get_reconcile_line
original_amount = amount = net_amount = line.debit - line.credit
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1154, in __get__
record.ensure_one()
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5204, in ensure_one
raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: account.move.line(208, 211, 212)
TT55221
|
Hi @etobella, |
etobella
approved these changes
Feb 24, 2025
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 09fa72a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding the singleton error related to
_get_reconcile_line()Related to #694
Please @pedrobaeza and @etobella can you review it?
@Tecnativa TT55221