Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_reconcile_oca #808

Open
wants to merge 210 commits into
base: 18.0
Choose a base branch
from

Conversation

JordiBForgeFlow
Copy link
Member

@JordiBForgeFlow JordiBForgeFlow commented Feb 25, 2025

etobella and others added 28 commits February 25, 2025 18:30
* In "reconcile" tab, don't propose the move of the currently processed statement line

* In accounting, only select/search parent partners
* refactoring JS in order to add logic
* Improve views
* Minor fixes in Odoo code in order to fix all possible options
…of account move number (name) fot the counterpart account move line
Currently translated at 1.0% (1 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/es/
Currently translated at 25.0% (23 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/hr/
Currently translated at 81.5% (75 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/tr/
By default, account_account name is a char field. But if
l10n_multilang is installed, it is translatable, hence
the DB column is now a jsonb.
We must handle both cases in the select query.
Currently translated at 76.0% (70 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/pt_BR/
Currently translated at 100.0% (92 of 92 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_reconcile_oca/fr/
etobella and others added 24 commits February 25, 2025 18:30
We will use currency of the line in order to get the suspense and max line value
Fix the case of payment with a foreign currency set on bank statement line

improve tests around multi-currency
…rrency rate

It is possible that the statement line in foreign currency is created before the rate of the day is updated in Odoo. In this case we need to take the real rate of the statement line to comput the exchange rate
…ount

If currency amount is not 0, the suspense line will have wrong amount
…er_id without onchange or subsequent changes with the _synchronize_to_moves() method.

We do not define partner_id with the value of manual_partner_id to prevent _synchronize_to_moves()
from making changes to the account.move.line leaving unintended values and/or data.

Re-define the value of reconcile_data_info if the _synchronize_to_moves() method has changed
anything on the lines.

Related to OCA#779

TT52634
We need to look at the reconcile_data to find the partner as the manual_partner_id can contain the information of an auxiliary line
We cant to avoid to change amounts on accounting entries during the reconciliation process. One of the goal is to avoid a following case :
The statement line is created in a foreign currency journal, later, the rate is updated in Odoo.
During reconciliation process, the partner is set on liquidity line, the accounting entries are synchronized and the balance changes.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-17.0/account-reconcile-17.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_reconcile_oca/
Currently translated at 100.0% (122 of 122 strings)

Translation: account-reconcile-17.0/account-reconcile-17.0-account_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_reconcile_oca/it/
… log

WARNING prod py.warnings: /opt/odoo/auto/addons/account_reconcile_oca/models/account_bank_statement_line.py:616: DeprecationWarning: Since 17.0, deprecated method, read display_name instead
… to avoid warning log

WARNING prod py.warnings: /opt/odoo/auto/addons/account/models/account_move.py:4651: UserWarning: unsupported operand type(s) for "==": 'res.partner()' == '403'
@JordiBForgeFlow JordiBForgeFlow force-pushed the 18.0-mig-account_reconcile_oca branch from 43f87b4 to 203719b Compare February 25, 2025 17:31
@JordiBForgeFlow JordiBForgeFlow force-pushed the 18.0-mig-account_reconcile_oca branch from 203719b to d4b9d8f Compare February 25, 2025 17:33
@JordiBForgeFlow
Copy link
Member Author

@etobella All is green here

@victoralmau
Copy link
Member

Please, cherry-pick #809 to commit history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.