Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] account_reconcile_oca: Avoiding the singleton error related to _get_reconcile_line() #809

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[17.0][FIX] account_reconcile_oca: Avoiding the singleton error related to _get_reconcile_line() #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions account_reconcile_oca/models/account_bank_statement_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,13 +684,16 @@
reconciled_line.move_id.journal_id
== self.company_id.currency_exchange_journal_id
):
reconcile_auxiliary_id, lines = self._get_reconcile_line(
reconciled_line.move_id.line_ids - reconciled_line,
"other",
from_unreconcile=False,
move=True,
)
data += lines
for rl_item in (
reconciled_line.move_id.line_ids - reconciled_line
):
reconcile_auxiliary_id, lines = self._get_reconcile_line(

Check warning on line 690 in account_reconcile_oca/models/account_bank_statement_line.py

View check run for this annotation

Codecov / codecov/patch

account_reconcile_oca/models/account_bank_statement_line.py#L690 

Added line #L690 was not covered by tests
rl_item,
"other",
from_unreconcile=False,
move=True,
)
data += lines

Check warning on line 696 in account_reconcile_oca/models/account_bank_statement_line.py

View check run for this annotation

Codecov / codecov/patch

account_reconcile_oca/models/account_bank_statement_line.py#L696 

Added line #L696 was not covered by tests
continue
partial = partial_lines.filtered(
lambda r, line=reconciled_line: r.debit_move_id == line
Expand Down