[16.0][IMP] crm_salesperson_planner: Refactoring of the template to make it usable and with simplified code #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes done: - Removed the (unnecessary) recurrence field from templates. - Recurrence fields (from calendar.event) are set as store=True. - Create an onchange to avoid inconsistent values by UX. - Modified the form view to make it more functional (similar to calendar.event). - Consider in _get_max_date() if a deadline (until) has been set. TT48238
… usable and with simplified code. TT48238
sergio-teruel
approved these changes
Mar 25, 2024
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at d67b985. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 15.0: #553 + #558
Changes done:
recurrencefield from templates.calendar.event) are set as store=True._get_max_date()if a deadline (until) has been set.Before:
After:
Please @sergio-teruel and @pedrobaeza can you review it?
@Tecnativa TT48238