Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] crm_won_restrict_per_stage: Add ValidationError to onchange to prevent display incorrect UX changes #569

Merged

Conversation

victoralmau
Copy link
Member

Add ValidationError to onchange to prevent display incorrect UX changes (stage)

Before
antes

After
despues

Please @pedrobaeza can you review it?

@Tecnativa TT49558

@OCA-git-bot
Copy link
Contributor

Hi @carolina-fernandez,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 7, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the occasion to put the proper maintainer.

@victoralmau victoralmau force-pushed the 16.0-imp-crm_won_restrict_per_stage-TT49558 branch from 5e4647f to 8d8cb69 Compare June 10, 2024 06:58
@pedrobaeza pedrobaeza requested a review from CarlosRoca13 June 10, 2024 07:00
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-569-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3567e7b into OCA:16.0 Jun 10, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 85d2453. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-crm_won_restrict_per_stage-TT49558 branch June 10, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants