[MIG] crm_lead_code: Migration to 18.0 #609

HeliconiaSolutions · 2024-11-25T12:31:03Z

No description provided.

bhaveshselarka

Functional Review, LGTM

CRogos

Could you cleanup the bot commits? I've marked some examples, but there are more.

I hope the the push will also recreate the runboat for testing

[UPD] prefix versions with 8.0

HeliconiaSolutions · 2025-02-21T05:20:56Z

@CRogos , Please review.it's done!

CRogos · 2025-02-21T09:44:26Z

There are still more commits which can be merged.
Here is a link to the migration documentation: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

HeliconiaSolutions · 2025-02-21T12:15:03Z

@CRogos, Please review!

CRogos · 2025-02-21T16:33:54Z

do you know why the tests are failing? Maybe we should make a rebase?

also there are still some weblate and oca-* commits.

CRogos

Code review LGTM and it is working.

Not sure why the tests fail, and some Commits can still be squashed.

Currently translated at 100.0% (3 of 3 strings) Translation: crm-10.0/crm-10.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-10-0/crm-10-0-crm_lead_code/de/

[UPD] Update crm_lead_code.pot

Currently translated at 100.0% (3 of 3 strings) Translation: crm-12.0/crm-12.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_code/pt_BR/

[UPD] Update crm_lead_code.pot [UPD] README.rst

[UPD] Update crm_lead_code.pot

Currently translated at 100.0% (6 of 6 strings) Translation: crm-14.0/crm-14.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es_AR/

Currently translated at 100.0% (3 of 3 strings) Translation: crm-14.0/crm-14.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es/

Currently translated at 100.0% (3 of 3 strings) Translation: crm-15.0/crm-15.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/fr/

Currently translated at 100.0% (3 of 3 strings) Translation: crm-15.0/crm-15.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/ca/

Currently translated at 66.6% (2 of 3 strings) Translation: crm-15.0/crm-15.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/it/

Currently translated at 25.0% (1 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/sl/

Currently translated at 100.0% (4 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/it/

Currently translated at 100.0% (4 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es/

Currently translated at 100.0% (4 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es_AR/

Currently translated at 75.0% (3 of 4 strings) Translation: crm-17.0/crm-17.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/

Currently translated at 100.0% (4 of 4 strings) Translation: crm-17.0/crm-17.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/

…ield

HeliconiaSolutions · 2025-02-25T09:02:03Z

Hello @CRogos Commits are squashed and Tests are also clear now.

OCA-git-bot · 2025-02-25T09:14:00Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

CRogos

Sorry, just found one more thing.

CRogos · 2025-02-25T10:57:36Z

crm_lead_code/models/crm_lead.py

-        ("crm_lead_unique_code", "UNIQUE (code)", _("The code must be unique!")),
+        ("crm_lead_unique_code", "UNIQUE (code)", "The code must be unique!"),


This change is not correct.
You should replace _ by self.env._ or assign _ = self.env._

https://www.odoo.com/documentation/18.0/contributing/development/coding_guidelines.html#use-translation-method-correctly

Or was it intended to remove the translation?

HeliconiaSolutions force-pushed the 18.0-mig-crm_lead_code branch from 8bbb507 to 427245d Compare November 27, 2024 05:20

bhaveshselarka approved these changes Nov 27, 2024

View reviewed changes

CRogos reviewed Feb 20, 2025

View reviewed changes

oihane and others added 4 commits February 21, 2025 10:29

[ADD] New module <crm_lead_code>

baefdb9

[IMP] <crm_lead_code> Code made visible in opportunities

307f78d

[UPD] prefix versions with 8.0

[MIG] Make modules uninstallable

38c2cec

[MIG] Rename manifest files

0a1df06

HeliconiaSolutions force-pushed the 18.0-mig-crm_lead_code branch 2 times, most recently from f6d7aea to 6d4d297 Compare February 21, 2025 05:06

HeliconiaSolutions force-pushed the 18.0-mig-crm_lead_code branch from 6d4d297 to 8fe6ace Compare February 21, 2025 12:11

HeliconiaSolutions requested a review from CRogos February 21, 2025 12:15

CRogos approved these changes Feb 21, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 21, 2025

nicolasramos and others added 13 commits February 25, 2025 14:15

[10.0][MIG] crm_lead_code (OCA#156)

2135a81

remove obsolete .pot files [ci skip]

795ee45

Translated using Weblate (German)

b57c1da

Currently translated at 100.0% (3 of 3 strings) Translation: crm-10.0/crm-10.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-10-0/crm-10-0-crm_lead_code/de/

[MIG] crm_lead_code: Migration to 12.0

97ead0e

[UPD] Update crm_lead_code.pot

Translated using Weblate (Portuguese (Brazil))

4b3042b

Currently translated at 100.0% (3 of 3 strings) Translation: crm-12.0/crm-12.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_code/pt_BR/

[WIP][13.0][MIG] crm_lead_code

df5ac3d

[FIX] Travis

dbfb348

[UPD] Update crm_lead_code.pot [UPD] README.rst

[MIG] crm_lead_code: Migration to 14.0

31217e1

[UPD] Update crm_lead_code.pot

Added translation using Weblate (Spanish (Argentina))

1a8cfc1

Translated using Weblate (Spanish (Argentina))

6905591

Currently translated at 100.0% (6 of 6 strings) Translation: crm-14.0/crm-14.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es_AR/

Translated using Weblate (Spanish)

dfdc9ec

Currently translated at 100.0% (3 of 3 strings) Translation: crm-14.0/crm-14.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es/

[MIG] crm_lead_code: Migration to 15.0

2709ae6

Added translation using Weblate (Catalan)

3cd54b3

ajaniszewska-dev and others added 13 commits February 25, 2025 14:15

Translated using Weblate (French)

4a9f3bb

Currently translated at 100.0% (3 of 3 strings) Translation: crm-15.0/crm-15.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/fr/

Translated using Weblate (Catalan)

ec029cd

Currently translated at 100.0% (3 of 3 strings) Translation: crm-15.0/crm-15.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/ca/

Translated using Weblate (Italian)

20593bc

Currently translated at 66.6% (2 of 3 strings) Translation: crm-15.0/crm-15.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/it/

[MIG] crm_lead_code: Migration to 16.0

b244676

Translated using Weblate (Slovenian)

2eb47df

Currently translated at 25.0% (1 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/sl/

Translated using Weblate (Italian)

15e60ba

Currently translated at 100.0% (4 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/it/

Translated using Weblate (Spanish)

1f9522b

Currently translated at 100.0% (4 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es/

Translated using Weblate (Spanish (Argentina))

4cc0028

Currently translated at 100.0% (4 of 4 strings) Translation: crm-16.0/crm-16.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es_AR/

[MIG] crm_lead_code: Migration to 17.0

3b2037e

Translated using Weblate (Portuguese (Brazil))

b100cde

Currently translated at 75.0% (3 of 4 strings) Translation: crm-17.0/crm-17.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/

Translated using Weblate (Portuguese (Brazil))

6c244ca

Currently translated at 100.0% (4 of 4 strings) Translation: crm-17.0/crm-17.0-crm_lead_code Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/

[IMP] crm_lead_code: space get removed when other view changes name f…

246cd1c

…ield

[IMP] crm_lead_code: pre-commit auto fixes

bb5eac4

HeliconiaSolutions force-pushed the 18.0-mig-crm_lead_code branch from 8fe6ace to 9193810 Compare February 25, 2025 08:45

[MIG] crm_lead_code: Migration to 18.0

b9c09ab

HeliconiaSolutions force-pushed the 18.0-mig-crm_lead_code branch from 9193810 to b9c09ab Compare February 25, 2025 08:49

OCA-git-bot added the ready to merge label Feb 25, 2025

CRogos suggested changes Feb 25, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Feb 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] crm_lead_code: Migration to 18.0 #609

[MIG] crm_lead_code: Migration to 18.0 #609

HeliconiaSolutions commented Nov 25, 2024

bhaveshselarka left a comment

CRogos left a comment

HeliconiaSolutions commented Feb 21, 2025

CRogos commented Feb 21, 2025

HeliconiaSolutions commented Feb 21, 2025

CRogos commented Feb 21, 2025

CRogos left a comment

HeliconiaSolutions commented Feb 25, 2025

OCA-git-bot commented Feb 25, 2025

CRogos left a comment

CRogos Feb 25, 2025

		("crm_lead_unique_code", "UNIQUE (code)", _("The code must be unique!")),
		("crm_lead_unique_code", "UNIQUE (code)", "The code must be unique!"),

[MIG] crm_lead_code: Migration to 18.0 #609

Are you sure you want to change the base?

[MIG] crm_lead_code: Migration to 18.0 #609

Conversation

HeliconiaSolutions commented Nov 25, 2024

bhaveshselarka left a comment

Choose a reason for hiding this comment

CRogos left a comment

Choose a reason for hiding this comment

HeliconiaSolutions commented Feb 21, 2025

CRogos commented Feb 21, 2025

HeliconiaSolutions commented Feb 21, 2025

CRogos commented Feb 21, 2025

CRogos left a comment

Choose a reason for hiding this comment

HeliconiaSolutions commented Feb 25, 2025

OCA-git-bot commented Feb 25, 2025

CRogos left a comment

Choose a reason for hiding this comment

CRogos Feb 25, 2025

Choose a reason for hiding this comment